Skip to content

Commit 891c818

Browse files
committed
docs: [#281] mark issue as completed
1 parent 040c38f commit 891c818

1 file changed

Lines changed: 17 additions & 16 deletions

File tree

docs/issues/281-strengthen-domain-invariant-enforcement.md

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
**Issue**: [#281](https://github.com/torrust/torrust-tracker-deployer/issues/281)
44
**Type**: Refactor
5-
**Status**: In Progress
5+
**Status**: ✅ Completed
66

77
## Overview
88

@@ -34,27 +34,28 @@ See: [`docs/refactors/plans/strengthen-domain-invariant-enforcement.md`](../refa
3434
- [x] `TryFrom<HttpApiSection> for HttpApiConfig`
3535
- [x] Documentation and ADRs
3636

37-
### Phase 1: Tracker Configuration Types
37+
### Phase 1: Tracker Configuration Types
3838

39-
- [ ] `UdpTrackerConfig` - validated constructor, private fields, getters
40-
- [ ] `HttpTrackerConfig` - validated constructor, private fields, getters
41-
- [ ] `HealthCheckApiConfig` - validated constructor, private fields, getters
42-
- [ ] `TryFrom` implementations for each DTO section
39+
- [x] `UdpTrackerConfig` - validated constructor, private fields, getters
40+
- [x] `HttpTrackerConfig` - validated constructor, private fields, getters
41+
- [x] `HealthCheckApiConfig` - validated constructor, private fields, getters
42+
- [x] `TryFrom` implementations for each DTO section
4343

44-
### Phase 2: Cross-Cutting Invariants
44+
### Phase 2: Cross-Cutting Invariants
4545

46-
- [ ] `TrackerCoreConfig` - database configuration validation
47-
- [ ] `TrackerConfig` - validates at construction (socket conflicts)
48-
- [ ] `UserInputs` - validated constructor (Grafana requires Prometheus)
46+
- [x] `TrackerCoreConfig` - database configuration validation
47+
- [x] `TrackerConfig` - validates at construction (socket conflicts)
48+
- [x] `UserInputs` - validated constructor (Grafana requires Prometheus)
49+
- [x] `HttpsConfig` - validated constructor (email validation)
4950

5051
## Acceptance Criteria
5152

52-
- [ ] All domain configuration types use validated constructors
53-
- [ ] All fields are private with getter methods
54-
- [ ] All types implement custom `Deserialize` with validation
55-
- [ ] All DTO→Domain conversions use `TryFrom` trait
56-
- [ ] Validation logic moved from application to domain layer
57-
- [ ] Pre-commit checks pass: `./scripts/pre-commit.sh`
53+
- [x] All domain configuration types use validated constructors
54+
- [x] All fields are private with getter methods
55+
- [x] All types implement custom `Deserialize` with validation
56+
- [x] All DTO→Domain conversions use `TryFrom` trait
57+
- [x] Validation logic moved from application to domain layer
58+
- [x] Pre-commit checks pass: `./scripts/pre-commit.sh`
5859

5960
## Contributing Guide
6061

0 commit comments

Comments
 (0)