Merge #426: feat: [#252] implement dynamic image detection for vulnerability scanning

af3fc7b feat: [#252] implement dynamic image detection for vulnerability scanning (Jose Celano)

Pull request description:

  Closes #252

  ## Summary

  Implements dynamic Docker image detection for the Trivy vulnerability scanning workflow. Instead of a hardcoded image list, the workflow now builds the deployer CLI, creates a minimal environment, and extracts the image list from the `show` command JSON output — ensuring the scan matrix automatically updates whenever an image constant changes.

  ## Changes

  ### Domain Model
  - Added `DockerImage` value object (`src/shared/docker_image.rs`) with `repository`, `tag`, and `full_reference()` method
  - Added `docker_image()` static methods with constants to `TrackerConfig`, `MysqlServiceConfig`, `PrometheusConfig`, and `GrafanaConfig`
  - Added `docker_image()` delegation in `DatabaseConfig` (returns `Some` for MySQL, `None` for SQLite)

  ### Infrastructure / Template
  - Added `image: String` field to all four service context structs (`TrackerServiceContext`, `MysqlServiceContext`, `PrometheusServiceContext`, `GrafanaServiceContext`)
  - Updated `templates/docker-compose/docker-compose.yml.tera` to use `{{ tracker.image }}`, `{{ mysql.image }}`, `{{ prometheus.image }}`, `{{ grafana.image }}` instead of hardcoded strings

  ### Show Command
  - Added `DockerImagesInfo` DTO (extracted to its own module `show/info/docker_images.rs`)
  - Added `docker_images: DockerImagesInfo` field to `EnvironmentInfo` (always populated, not optional)
  - Updated show handler to populate `docker_images` from domain config constants
  - Updated text view to render a **Docker Images** section
  - Updated JSON output — `docker_images` is now present in all states

  ### GitHub Actions Workflow
  - Added `extract-images` job: builds CLI → creates minimal env → runs `show ci-images` → pipes JSON to `jq` to produce image array
  - Updated `scan-third-party-images` to use `${{ fromJson(needs.extract-images.outputs.images) }}` matrix (fully dynamic)
  - Replaced 5 hardcoded third-party SARIF upload steps with a single bash loop in `upload-sarif-results`
  - Added `src/**` to workflow trigger paths so image constant changes trigger re-scans

  ## Verification

  All commands tested locally:
  ```bash
  ./target/release/torrust-tracker-deployer --working-dir /tmp/ci-workspace create environment --env-file /tmp/ci-images-env.json
  ./target/release/torrust-tracker-deployer --working-dir /tmp/ci-workspace show ci-images
  # jq output: ["torrust/tracker:develop","mysql:8.4","prom/prometheus:v3.5.0","grafana/grafana:12.3.1","caddy:2.10"]
  ```

  Pre-commit checks: ✅ 425/425 tests pass, all linters pass.

ACKs for top commit:
  josecelano:
    ACK af3fc7b

Tree-SHA512: 1eb54e311fe3b87673a60e0427561414cbc2e5f710e1df17c7052074a092e17d47e663441e0d3f817477bfaca0bce98cf4cd90317c8917b484cd6e755ec8042a

Author: josecelano

.github/workflows/docker-security-scan.yml

@@ -6,16 +6,18 @@ on:
     paths:
       - "docker/**"
       - "templates/docker-compose/**"
+      - "src/**"
       - ".github/workflows/docker-security-scan.yml"
 
   pull_request:
     paths:
       - "docker/**"
       - "templates/docker-compose/**"
+      - "src/**"
       - ".github/workflows/docker-security-scan.yml"
 
   # Scheduled scans are important because new CVEs appear
-  # even if the code or images didn’t change
+  # even if the code or images didn't change
   schedule:
     - cron: "0 6 * * *" # Daily at 6 AM UTC
 
@@ -60,7 +62,7 @@ jobs:
             ${{ matrix.image.context }}
 
       # Human-readable output in logs
-      # This NEVER fails the job; it’s only for visibility
+      # This NEVER fails the job; it's only for visibility
       - name: Display vulnerabilities (table format)
         uses: aquasecurity/trivy-action@0.35.0
         with:
@@ -93,8 +95,98 @@ jobs:
           path: trivy-${{ matrix.image.name }}.sarif
           retention-days: 30
 
+  extract-images:
+    name: Extract Third-Party Docker Images from Source
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    outputs:
+      # JSON array of Docker image references for use in scan matrix
+      # Example: ["torrust/tracker:develop","mysql:8.4","prom/prometheus:v3.5.0","grafana/grafana:12.3.1","caddy:2.10"]
+      images: ${{ steps.extract.outputs.images }}
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v5
+
+      - name: Install Rust toolchain
+        uses: actions-rust-lang/setup-rust-toolchain@v1
+
+      - name: Build deployer CLI
+        run: cargo build --release
+
+      # Creates a minimal environment config with all optional services
+      # enabled so that all third-party Docker images appear in the output.
+      # - MySQL: enables mysql image in docker_images output
+      # - Prometheus: enables prometheus image in docker_images output
+      # - Grafana: enables grafana image in docker_images output
+      # Uses fixture SSH keys (already committed to the repository).
+      - name: Create environment config for image extraction
+        run: |
+          cat > /tmp/ci-images-env.json <<EOF
+          {
+            "environment": { "name": "ci-images" },
+            "ssh_credentials": {
+              "private_key_path": "$GITHUB_WORKSPACE/fixtures/testing_rsa",
+              "public_key_path": "$GITHUB_WORKSPACE/fixtures/testing_rsa.pub"
+            },
+            "provider": {
+              "provider": "lxd",
+              "profile_name": "ci-profile"
+            },
+            "tracker": {
+              "core": {
+                "database": {
+                  "driver": "mysql",
+                  "host": "mysql",
+                  "port": 3306,
+                  "database_name": "torrust_tracker",
+                  "username": "tracker_user",
+                  "password": "tracker_password"
+                },
+                "private": false
+              },
+              "udp_trackers": [{ "bind_address": "0.0.0.0:6969" }],
+              "http_trackers": [{ "bind_address": "0.0.0.0:7070" }],
+              "http_api": { "bind_address": "0.0.0.0:1212", "admin_token": "ci-token" },
+              "health_check_api": { "bind_address": "127.0.0.1:1313" }
+            },
+            "prometheus": { "scrape_interval_in_secs": 15 },
+            "grafana": { "admin_user": "admin", "admin_password": "admin" }
+          }
+          EOF
+
+      - name: Create minimal environment (no infrastructure provisioned)
+        run: |
+          ./target/release/torrust-tracker-deployer \
+            --working-dir /tmp/ci-workspace \
+            create environment \
+            --env-file /tmp/ci-images-env.json
+
+      # Extract Docker images from show command JSON output.
+      # The show command lists all configured service images in docker_images.
+      # Caddy is always in the docker-compose stack but is not tracked as
+      # a domain service, so it is appended to the list manually.
+      - name: Extract Docker images
+        id: extract
+        run: |
+          show_output=$(./target/release/torrust-tracker-deployer \
+            --working-dir /tmp/ci-workspace \
+            show ci-images)
+
+          images=$(echo "$show_output" | \
+            jq -c '[
+              .docker_images.tracker,
+              .docker_images.mysql,
+              .docker_images.prometheus,
+              .docker_images.grafana
+            ] | map(select(. != null)) + ["caddy:2.10"]')
+
+          echo "Detected images: $images"
+          echo "images=$images" >> "$GITHUB_OUTPUT"
+
   scan-third-party-images:
     name: Scan Third-Party Docker Images
+    needs: extract-images
     runs-on: ubuntu-latest
     timeout-minutes: 15
     permissions:
@@ -103,14 +195,9 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        # These must match docker-compose templates
-        # in templates/docker-compose/docker-compose.yml.tera
-        image:
-          - torrust/tracker:develop
-          - mysql:8.0
-          - grafana/grafana:11.4.0
-          - prom/prometheus:v3.0.1
-          - caddy:2.10
+        # Dynamic image list extracted from the deployer CLI at build time.
+        # Images come from domain config constants — no manual maintenance needed.
+        image: ${{ fromJson(needs.extract-images.outputs.images) }}
 
     steps:
       - name: Display vulnerabilities (table format)
@@ -154,7 +241,7 @@ jobs:
       - scan-project-images
       - scan-third-party-images
 
-    # Always run so we don’t lose security visibility
+    # Always run so we don't lose security visibility
     if: always()
 
     permissions:
@@ -168,7 +255,6 @@ jobs:
 
       # Upload each SARIF file with CodeQL Action using unique categories.
       # The category parameter enables proper alert tracking per image.
-      # Must use CodeQL Action (not gh API) - API doesn't support category field.
       #
       # VIEWING RESULTS:
       # - For pull requests: /security/code-scanning?query=pr:NUMBER+is:open
@@ -192,42 +278,41 @@ jobs:
           category: docker-project-ssh-server
         continue-on-error: true
 
-      - name: Upload third-party mysql SARIF
-        if: always()
-        uses: github/codeql-action/upload-sarif@v4
-        with:
-          sarif_file: sarif-third-party-mysql-8.0-${{ github.run_id }}/trivy.sarif
-          category: docker-third-party-mysql-8.0
-        continue-on-error: true
-
-      - name: Upload third-party tracker SARIF
+      # Dynamic upload of all third-party image SARIF results.
+      # Iterates over every sarif-third-party-* artifact directory so
+      # no manual step additions are needed when images change version.
+      # The category is derived from the artifact directory name so
+      # GitHub Code Scanning properly tracks alerts per image.
+      - name: Upload all third-party SARIF results
         if: always()
-        uses: github/codeql-action/upload-sarif@v4
-        with:
-          sarif_file: sarif-third-party-torrust-tracker-develop-${{ github.run_id }}/trivy.sarif
-          category: docker-third-party-torrust-tracker-develop
-        continue-on-error: true
+        env:
+          GH_TOKEN: ${{ github.token }}
+        shell: bash
+        run: |
+          for sarif_dir in sarif-third-party-*; do
+            if [[ ! -d "$sarif_dir" ]]; then
+              continue
+            fi
+            sarif_file="$sarif_dir/trivy.sarif"
+            if [[ ! -f "$sarif_file" ]]; then
+              echo "No SARIF file in $sarif_dir, skipping"
+              continue
+            fi
 
-      - name: Upload third-party grafana SARIF
-        if: always()
-        uses: github/codeql-action/upload-sarif@v4
-        with:
-          sarif_file: sarif-third-party-grafana-grafana-11.4.0-${{ github.run_id }}/trivy.sarif
-          category: docker-third-party-grafana-grafana-11.4.0
-        continue-on-error: true
+            # Derive unique Code Scanning category from the artifact directory name.
+            # Example: sarif-third-party-mysql-8.4-12345 -> docker-third-party-mysql-8.4
+            artifact_name="${sarif_dir%-${{ github.run_id }}}"
+            category="docker-${artifact_name#sarif-}"
 
-      - name: Upload third-party prometheus SARIF
-        if: always()
-        uses: github/codeql-action/upload-sarif@v4
-        with:
-          sarif_file: sarif-third-party-prom-prometheus-v3.0.1-${{ github.run_id }}/trivy.sarif
-          category: docker-third-party-prom-prometheus-v3.0.1
-        continue-on-error: true
+            echo "Uploading $sarif_file with category: $category"
 
-      - name: Upload third-party caddy SARIF
-        if: always()
-        uses: github/codeql-action/upload-sarif@v4
-        with:
-          sarif_file: sarif-third-party-caddy-2.10-${{ github.run_id }}/trivy.sarif
-          category: docker-third-party-caddy-2.10
-        continue-on-error: true
+            gh api \
+              --method POST \
+              -H "Accept: application/vnd.github+json" \
+              "/repos/${{ github.repository }}/code-scanning/sarifs" \
+              -f "commit_sha=${{ github.sha }}" \
+              -f "ref=${{ github.ref }}" \
+              -f "sarif=$(gzip -c "$sarif_file" | base64 -w 0)" \
+              -f "category=$category" \
+              || echo "Warning: Upload failed for $sarif_file (category: $category)"
+          done

project-words.txt

@@ -426,6 +426,7 @@ rustup
 rwxrwx
 sandboxed
 sarif
+sarifs
 scannability
 schemafile
 schemars

src/application/command_handlers/show/handler.rs

@@ -28,9 +28,15 @@ use std::sync::Arc;
 use tracing::instrument;
 
 use super::errors::ShowCommandHandlerError;
-use super::info::{EnvironmentInfo, GrafanaInfo, InfrastructureInfo, PrometheusInfo, ServiceInfo};
+use super::info::{
+    DockerImagesInfo, EnvironmentInfo, GrafanaInfo, InfrastructureInfo, PrometheusInfo, ServiceInfo,
+};
 use crate::domain::environment::repository::EnvironmentRepository;
 use crate::domain::environment::state::AnyEnvironmentState;
+use crate::domain::grafana::GrafanaConfig;
+use crate::domain::mysql::MysqlServiceConfig;
+use crate::domain::prometheus::PrometheusConfig;
+use crate::domain::tracker::config::TrackerConfig;
 use crate::domain::EnvironmentName;
 
 /// Default SSH port when not specified
@@ -121,7 +127,24 @@ impl ShowCommandHandler {
         let created_at = any_env.created_at();
         let state_name = any_env.state_name().to_string();
 
-        let mut info = EnvironmentInfo::new(name, state, provider, created_at, state_name);
+        let tracker_config = any_env.tracker_config();
+        let docker_images = DockerImagesInfo::new(
+            TrackerConfig::docker_image().full_reference(),
+            if tracker_config.uses_mysql() {
+                Some(MysqlServiceConfig::docker_image().full_reference())
+            } else {
+                None
+            },
+            any_env
+                .prometheus_config()
+                .map(|_| PrometheusConfig::docker_image().full_reference()),
+            any_env
+                .grafana_config()
+                .map(|_| GrafanaConfig::docker_image().full_reference()),
+        );
+
+        let mut info =
+            EnvironmentInfo::new(name, state, provider, created_at, docker_images, state_name);
 
         // Add infrastructure info if instance IP is available
         if let Some(instance_ip) = any_env.instance_ip() {
@@ -144,7 +167,6 @@ impl ShowCommandHandler {
             if Self::should_show_services(any_env.state_name()) {
                 // Always compute from tracker config to show proper service information
                 // including TLS domains, localhost hints, and HTTPS status
-                let tracker_config = any_env.tracker_config();
                 let grafana_config = any_env.grafana_config();
                 let services =
                     ServiceInfo::from_tracker_config(tracker_config, instance_ip, grafana_config);

src/application/command_handlers/show/info/docker_images.rs

@@ -0,0 +1,38 @@
+use serde::Serialize;
+
+/// Docker image information for the deployment stack
+///
+/// Contains the Docker image references for all services in the deployment.
+/// Optional services (`MySQL`, Prometheus, Grafana) are `None` if not configured.
+#[derive(Debug, Clone, Serialize)]
+pub struct DockerImagesInfo {
+    /// Tracker Docker image reference (e.g. `torrust/tracker:develop`)
+    pub tracker: String,
+
+    /// `MySQL` Docker image reference (e.g. `mysql:8.4`), present when `MySQL` is configured
+    pub mysql: Option<String>,
+
+    /// Prometheus Docker image reference (e.g. `prom/prometheus:v3.5.0`), present when configured
+    pub prometheus: Option<String>,
+
+    /// Grafana Docker image reference (e.g. `grafana/grafana:12.3.1`), present when configured
+    pub grafana: Option<String>,
+}
+
+impl DockerImagesInfo {
+    /// Create a new `DockerImagesInfo` with the tracker image and optional service images
+    #[must_use]
+    pub fn new(
+        tracker: String,
+        mysql: Option<String>,
+        prometheus: Option<String>,
+        grafana: Option<String>,
+    ) -> Self {
+        Self {
+            tracker,
+            mysql,
+            prometheus,
+            grafana,
+        }
+    }
+}