refactor: [#281] rename Environment constructor to create

Rename with_working_dir_and_tracker() to create() for cleaner,
more idiomatic API. The new name is concise and clearly indicates
this is the primary factory method for creating a fully-configured
Environment aggregate.

Author: josecelano

docs/e2e-testing/manual/grafana-verification.md

@@ -641,8 +641,8 @@ docker exec <grafana_container_id> env | grep GF_SECURITY_ADMIN_PASSWORD
 This was a bug where the configured password wasn't being passed from the environment config to the `.env` file. It was fixed by updating:
 
 - `UserInputs::with_tracker()` to accept optional Prometheus/Grafana configs
-- `EnvironmentContext::with_working_dir_and_tracker()` to pass configs through
-- `Environment::with_working_dir_and_tracker()` to accept configs
+- `EnvironmentContext::create()` to pass configs through
+- `Environment::create()` to accept configs
 - Create handler to pass configs instead of using defaults
 
 **Solution:**

docs/refactors/plans/strengthen-domain-invariant-enforcement.md

@@ -815,7 +815,7 @@ EnvironmentCreationConfig  →   Build partial domain objects:
                                         ↓
                                UserInputs validates cross-cutting invariants
                                         ↓
-                               Environment::with_working_dir_and_tracker()
+                               Environment::create()
                                creates the complete aggregate
 ```
 
@@ -915,7 +915,7 @@ Then update `EnvironmentContext` to use the validated constructor:
 
 ```rust
 impl EnvironmentContext {
-    pub fn with_working_dir_and_tracker(
+    pub fn create(
         // ... params ...
     ) -> Result<Self, UserInputsError> {
         let user_inputs = UserInputs::new(
@@ -960,8 +960,8 @@ impl EnvironmentContext {
 - [x] Create `UserInputsError` enum with `help()` method in `user_inputs.rs`
 - [x] Change `UserInputs::new()` to return `Result<Self, UserInputsError>`
 - [x] Add cross-service validation to `UserInputs::with_tracker()`
-- [x] Update `EnvironmentContext::with_working_dir_and_tracker()` to propagate errors
-- [x] Update `Environment::with_working_dir_and_tracker()` to return `Result`
+- [x] Update `EnvironmentContext::create()` to propagate errors
+- [x] Update `Environment::create()` to return `Result`
 - [x] Add `From<UserInputsError>` impl for `CreateConfigError` in application layer
 - [x] Remove duplicate validation from `EnvironmentCreationConfig::to_environment_params()`
 - [x] Update all call sites that create `UserInputs` directly
@@ -989,7 +989,7 @@ impl EnvironmentContext {
 
 4. **Updated `EnvironmentContext`**:
    - `new()` uses `.expect()` since defaults always pass validation
-   - `with_working_dir_and_tracker()` returns `Result<Self, UserInputsError>`
+   - `create()` returns `Result<Self, UserInputsError>`
 
 5. **Added `TrackerConfig::has_any_tls_configured()`** method to check TLS status
 
@@ -1006,7 +1006,7 @@ impl EnvironmentContext {
 
 #### Migration Notes
 
-This change makes `Environment::with_working_dir_and_tracker()` fallible, which is a breaking change. However:
+This change makes `Environment::create()` fallible, which is a breaking change. However:
 
 1. The function is primarily called from `CreateCommandHandler::execute()` which already handles errors
 2. Test helpers may need updating to use `.expect()` or propagate errors

src/application/command_handlers/create/handler.rs

@@ -234,7 +234,7 @@ impl CreateCommandHandler {
         }
 
         // Create environment aggregate from validated params
-        let environment = Environment::with_working_dir_and_tracker(
+        let environment = Environment::create(
             params.environment_name,
             params.provider_config,
             params.ssh_credentials,

src/domain/environment/context.rs

@@ -223,7 +223,7 @@ impl EnvironmentContext {
     /// - `HttpsSectionWithoutTlsServices` if HTTPS section exists but no service uses TLS
     /// - `TlsServicesWithoutHttpsSection` if a service uses TLS but HTTPS section is missing
     #[allow(clippy::too_many_arguments)] // Public API with necessary configuration parameters
-    pub fn with_working_dir_and_tracker(
+    pub fn create(
         name: &EnvironmentName,
         provider_config: ProviderConfig,
         ssh_credentials: SshCredentials,

src/domain/environment/mod.rs

@@ -310,7 +310,7 @@ impl Environment {
     /// - `TlsServicesWithoutHttpsSection`: Service has TLS but HTTPS section is missing
     #[allow(clippy::needless_pass_by_value)] // Public API takes ownership for ergonomics
     #[allow(clippy::too_many_arguments)] // Public API with necessary configuration parameters
-    pub fn with_working_dir_and_tracker(
+    pub fn create(
         name: EnvironmentName,
         provider_config: ProviderConfig,
         ssh_credentials: SshCredentials,
@@ -322,7 +322,7 @@ impl Environment {
         working_dir: &std::path::Path,
         created_at: DateTime<Utc>,
     ) -> Result<Environment<Created>, UserInputsError> {
-        let context = EnvironmentContext::with_working_dir_and_tracker(
+        let context = EnvironmentContext::create(
             &name,
             provider_config,
             ssh_credentials,