feat: [#275] Change Grafana default port from 3100 to 3000#276
Merged
Conversation
- Update docker-compose template to expose Grafana on port 3000 - Update Rust source code constants and test assertions - Update all active documentation referencing port 3100 - Add ADR documenting the port change decision The previous port 3100 was a workaround for Docker on macOS, where AirPlay uses port 5000 and AirTunes uses port 7000. However, port 3000 is the industry standard for Grafana and was never actually conflicting. Fixes #275
Member
Author
|
ACK c038170 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the Grafana default port from 3100 to 3000, aligning with the industry standard.
Changes
docker-compose.yml.terato expose Grafana on port 3000DEFAULT_GRAFANA_PORTconstant and all test assertionsgrafana-default-port-3000.mddocumenting the decisionFiles Modified
Template
templates/docker-compose/docker-compose.yml.tera- Port mapping3100:3000→3000:3000Rust Source
src/infrastructure/remote_actions/validators/grafana.rs- Constant and docssrc/application/command_handlers/show/info/grafana.rs- URL generation and testssrc/presentation/views/commands/show/environment_info/grafana.rs- Test fixturessrc/testing/e2e/tasks/run_run_validation.rs- Error messagesDocumentation
docs/decisions/grafana-default-port-3000.mdRationale
Port 3000 is the industry standard for Grafana. The original use of port 3100 was a workaround for macOS port conflicts, but:
Testing
Fixes #275