fix: [#412] include UDP tracker domains in provision output and DNS reminder#419
Merged
josecelano merged 1 commit intotorrust:mainfrom Apr 6, 2026
Conversation
Member
Author
|
ACK bca1a2a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #412 — UDP tracker domains were missing from the
provisioncommand outputdomainsarray and the DNS setup reminder.Root Cause
ProvisionDetailsDataandDnsReminderView::extract_all_domainsboth calledServiceInfo::tls_domain_names(), which only returns domains for TLS-enabled HTTP services. UDP trackers are not TLS services, so their domains were never included.Changes
src/application/command_handlers/show/info/tracker.rsall_domain_names() -> Vec<&str>toServiceInfo: returns TLS service domains plus UDP tracker domains (when a domain name is configured). IP-only UDP trackers (nodomainfield) are excluded.extract_host_from_udp_url().tls_domain_names()is unchanged — the HTTPS-specific hint still uses it correctly.it_should_return_all_domain_names_including_udpit_should_exclude_udp_trackers_without_domain_from_all_domain_namessrc/presentation/cli/views/commands/provision/view_data/provision_details.rsFrom<&Environment<Provisioned>>: replacedtls_domain_names()call withall_domain_names().src/presentation/cli/views/commands/provision/view_data/dns_reminder.rsextract_all_domains(): replacedtls_domain_names()call withall_domain_names().it_should_include_udp_tracker_domains_in_extract_all_domains.Acceptance Criteria
provisionoutputdomainsarray includes UDP tracker domain names when configuredprovisionoutputdomainsarray does not include IP-only UDP trackerstls_domain_names()is unchanged./scripts/pre-commit.sh)Manual E2E Verification
Provisioned a local LXD VM with two UDP trackers each having a
domainconfigured. TheprovisionJSON output returned:Before the fix this array was empty (no HTTP/TLS services in the test config).