fix: [#437] restore third-party Trivy SARIF uploads#438
Merged
josecelano merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
Replace the unsupported custom gh API SARIF upload loop (HTTP 422 on category) with github/codeql-action/upload-sarif in the third-party matrix job. This restores third-party code scanning uploads with stable per-image categories and removes the broken dynamic upload loop from the aggregate upload job.
Member
Author
|
ACK b397688 |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Docker security scanning workflow so third-party Trivy SARIF results are uploaded through a supported path.
Changes
security-events: writepermission toscan-third-party-imagesgithub/codeql-action/upload-sarif@v4docker-third-party-${sanitized-image}gh api /code-scanning/sarifsupload loopWhy
The previous custom upload was failing with HTTP 422 (
"category" is not a permitted key) and silently skipping third-party uploads, which caused PR warnings likeconfigurations not found.Validation
cargo run --bin linter yamlpassesCloses #437