Skip to content

Commit 47d1eab

Browse files
committed
refactor: [#1358] Swarm tests to use new mock helpers
1 parent b13797e commit 47d1eab

1 file changed

Lines changed: 39 additions & 72 deletions

File tree

packages/torrent-repository/src/swarm.rs

Lines changed: 39 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -926,15 +926,13 @@ mod tests {
926926

927927
mod triggering_events {
928928

929-
use std::future;
930929
use std::sync::Arc;
931930

932931
use aquatic_udp_protocol::AnnounceEvent::Started;
933-
use mockall::predicate::eq;
934932
use torrust_tracker_primitives::peer::fixture::PeerBuilder;
935933
use torrust_tracker_primitives::DurationSinceUnixEpoch;
936934

937-
use crate::event::sender::tests::MockEventSender;
935+
use crate::event::sender::tests::{expect_event_sequence, MockEventSender};
938936
use crate::event::Event;
939937
use crate::swarm::Swarm;
940938
use crate::tests::sample_info_hash;
@@ -946,11 +944,7 @@ mod tests {
946944

947945
let mut event_sender_mock = MockEventSender::new();
948946

949-
event_sender_mock
950-
.expect_send()
951-
.with(eq(Event::PeerAdded { info_hash, peer }))
952-
.times(1)
953-
.returning(|_| Box::pin(future::ready(Some(Ok(1)))));
947+
expect_event_sequence(&mut event_sender_mock, vec![Event::PeerAdded { info_hash, peer }]);
954948

955949
let mut swarm = Swarm::new(&sample_info_hash(), 0, Some(Arc::new(event_sender_mock)));
956950

@@ -965,17 +959,10 @@ mod tests {
965959

966960
let mut event_sender_mock = MockEventSender::new();
967961

968-
event_sender_mock
969-
.expect_send()
970-
.with(eq(Event::PeerAdded { info_hash, peer }))
971-
.times(1)
972-
.returning(|_| Box::pin(future::ready(Some(Ok(1)))));
973-
974-
event_sender_mock
975-
.expect_send()
976-
.with(eq(Event::PeerRemoved { info_hash, peer }))
977-
.times(1)
978-
.returning(|_| Box::pin(future::ready(Some(Ok(1)))));
962+
expect_event_sequence(
963+
&mut event_sender_mock,
964+
vec![Event::PeerAdded { info_hash, peer }, Event::PeerRemoved { info_hash, peer }],
965+
);
979966

980967
let mut swarm = Swarm::new(&info_hash, 0, Some(Arc::new(event_sender_mock)));
981968

@@ -993,17 +980,10 @@ mod tests {
993980

994981
let mut event_sender_mock = MockEventSender::new();
995982

996-
event_sender_mock
997-
.expect_send()
998-
.with(eq(Event::PeerAdded { info_hash, peer }))
999-
.times(1)
1000-
.returning(|_| Box::pin(future::ready(Some(Ok(1)))));
1001-
1002-
event_sender_mock
1003-
.expect_send()
1004-
.with(eq(Event::PeerRemoved { info_hash, peer }))
1005-
.times(1)
1006-
.returning(|_| Box::pin(future::ready(Some(Ok(1)))));
983+
expect_event_sequence(
984+
&mut event_sender_mock,
985+
vec![Event::PeerAdded { info_hash, peer }, Event::PeerRemoved { info_hash, peer }],
986+
);
1007987

1008988
let mut swarm = Swarm::new(&info_hash, 0, Some(Arc::new(event_sender_mock)));
1009989

@@ -1024,21 +1004,17 @@ mod tests {
10241004

10251005
let mut event_sender_mock = MockEventSender::new();
10261006

1027-
event_sender_mock
1028-
.expect_send()
1029-
.with(eq(Event::PeerAdded { info_hash, peer }))
1030-
.times(1)
1031-
.returning(|_| Box::pin(future::ready(Some(Ok(1)))));
1032-
1033-
event_sender_mock
1034-
.expect_send()
1035-
.with(eq(Event::PeerUpdated {
1036-
info_hash,
1037-
old_peer: peer,
1038-
new_peer: peer,
1039-
}))
1040-
.times(1)
1041-
.returning(|_| Box::pin(future::ready(Some(Ok(1)))));
1007+
expect_event_sequence(
1008+
&mut event_sender_mock,
1009+
vec![
1010+
Event::PeerAdded { info_hash, peer },
1011+
Event::PeerUpdated {
1012+
info_hash,
1013+
old_peer: peer,
1014+
new_peer: peer,
1015+
},
1016+
],
1017+
);
10421018

10431019
let mut swarm = Swarm::new(&info_hash, 0, Some(Arc::new(event_sender_mock)));
10441020

@@ -1058,33 +1034,24 @@ mod tests {
10581034

10591035
let mut event_sender_mock = MockEventSender::new();
10601036

1061-
event_sender_mock
1062-
.expect_send()
1063-
.with(eq(Event::PeerAdded {
1064-
info_hash,
1065-
peer: started_peer,
1066-
}))
1067-
.times(1)
1068-
.returning(|_| Box::pin(future::ready(Some(Ok(1)))));
1069-
1070-
event_sender_mock
1071-
.expect_send()
1072-
.with(eq(Event::PeerUpdated {
1073-
info_hash,
1074-
old_peer: started_peer,
1075-
new_peer: completed_peer,
1076-
}))
1077-
.times(1)
1078-
.returning(|_| Box::pin(future::ready(Some(Ok(1)))));
1079-
1080-
event_sender_mock
1081-
.expect_send()
1082-
.with(eq(Event::PeerDownloadCompleted {
1083-
info_hash,
1084-
peer: completed_peer,
1085-
}))
1086-
.times(1)
1087-
.returning(|_| Box::pin(future::ready(Some(Ok(1)))));
1037+
expect_event_sequence(
1038+
&mut event_sender_mock,
1039+
vec![
1040+
Event::PeerAdded {
1041+
info_hash,
1042+
peer: started_peer,
1043+
},
1044+
Event::PeerUpdated {
1045+
info_hash,
1046+
old_peer: started_peer,
1047+
new_peer: completed_peer,
1048+
},
1049+
Event::PeerDownloadCompleted {
1050+
info_hash,
1051+
peer: completed_peer,
1052+
},
1053+
],
1054+
);
10881055

10891056
let mut swarm = Swarm::new(&info_hash, 0, Some(Arc::new(event_sender_mock)));
10901057

0 commit comments

Comments
 (0)