fic: [#1539] persisten metrics should be enabled by config

Author: josecelano

packages/tracker-core/src/statistics/event/handler.rs

@@ -13,6 +13,7 @@ pub async fn handle_event(
     event: Event,
     stats_repository: &Arc<Repository>,
     db_torrent_repository: &Arc<DatabasePersistentTorrentRepository>,
+    persistent_torrent_completed_stat: bool,
     now: DurationSinceUnixEpoch,
 ) {
     match event {
@@ -50,23 +51,25 @@ pub async fn handle_event(
                 )
                 .await;
 
-            // Increment the number of downloads for the torrent in the database
-            match db_torrent_repository.increase_number_of_downloads(&info_hash) {
-                Ok(()) => {
-                    tracing::debug!(info_hash = ?info_hash, "Number of torrent downloads increased");
+            if persistent_torrent_completed_stat {
+                // Increment the number of downloads for the torrent in the database
+                match db_torrent_repository.increase_number_of_downloads(&info_hash) {
+                    Ok(()) => {
+                        tracing::debug!(info_hash = ?info_hash, "Number of torrent downloads increased");
+                    }
+                    Err(err) => {
+                        tracing::error!(info_hash = ?info_hash, error = ?err, "Failed to increase number of downloads for the torrent");
+                    }
                 }
-                Err(err) => {
-                    tracing::error!(info_hash = ?info_hash, error = ?err, "Failed to increase number of downloads for the torrent");
-                }
-            }
 
-            // Increment the global number of downloads (for all torrents) in the database
-            match db_torrent_repository.increase_global_number_of_downloads() {
-                Ok(()) => {
-                    tracing::debug!("Global number of downloads increased");
-                }
-                Err(err) => {
-                    tracing::error!(error = ?err, "Failed to increase global number of downloads");
+                // Increment the global number of downloads (for all torrents) in the database
+                match db_torrent_repository.increase_global_number_of_downloads() {
+                    Ok(()) => {
+                        tracing::debug!("Global number of downloads increased");
+                    }
+                    Err(err) => {
+                        tracing::error!(error = ?err, "Failed to increase global number of downloads");
+                    }
                 }
             }
         }

packages/tracker-core/src/statistics/event/listener.rs

@@ -15,14 +15,21 @@ pub fn run_event_listener(
     receiver: Receiver,
     repository: &Arc<Repository>,
     db_torrent_repository: &Arc<DatabasePersistentTorrentRepository>,
+    persistent_torrent_completed_stat: bool,
 ) -> JoinHandle<()> {
     let stats_repository = repository.clone();
     let db_torrent_repository: Arc<DatabasePersistentTorrentRepository> = db_torrent_repository.clone();
 
     tracing::info!(target: TRACKER_CORE_LOG_TARGET, "Starting torrent repository event listener");
 
     tokio::spawn(async move {
-        dispatch_events(receiver, stats_repository, db_torrent_repository).await;
+        dispatch_events(
+            receiver,
+            stats_repository,
+            db_torrent_repository,
+            persistent_torrent_completed_stat,
+        )
+        .await;
 
         tracing::info!(target: TRACKER_CORE_LOG_TARGET, "Torrent repository listener finished");
     })
@@ -32,6 +39,7 @@ async fn dispatch_events(
     mut receiver: Receiver,
     stats_repository: Arc<Repository>,
     db_torrent_repository: Arc<DatabasePersistentTorrentRepository>,
+    persistent_torrent_completed_stat: bool,
 ) {
     let shutdown_signal = tokio::signal::ctrl_c();
 
@@ -48,7 +56,12 @@ async fn dispatch_events(
 
             result = receiver.recv() => {
                 match result {
-                    Ok(event) => handle_event(event, &stats_repository, &db_torrent_repository, CurrentClock::now()).await,
+                    Ok(event) => handle_event(
+                        event,
+                        &stats_repository,
+                        &db_torrent_repository,
+                        persistent_torrent_completed_stat,
+                        CurrentClock::now()).await,
                     Err(e) => {
                         match e {
                             RecvError::Closed => {

packages/tracker-core/tests/common/test_env.rs

@@ -78,6 +78,10 @@ impl TestEnv {
             self.torrent_repository_container.event_bus.receiver(),
             &self.tracker_core_container.stats_repository,
             &self.tracker_core_container.db_torrent_repository,
+            self.tracker_core_container
+                .core_config
+                .tracker_policy
+                .persistent_torrent_completed_stat,
         );
 
         jobs.push(job);

src/bootstrap/jobs/tracker_core.rs

@@ -11,6 +11,11 @@ pub fn start_event_listener(config: &Configuration, app_container: &Arc<AppConta
             app_container.torrent_repository_container.event_bus.receiver(),
             &app_container.tracker_core_container.stats_repository,
             &app_container.tracker_core_container.db_torrent_repository,
+            app_container
+                .tracker_core_container
+                .core_config
+                .tracker_policy
+                .persistent_torrent_completed_stat,
         );
 
         Some(job)