Merge #1886: chore(issues): maintain issue specs — archive closed, promote drafts, add new subissues

josecelano · josecelano · commit 78e0c002fd83 · 2026-06-05T18:10:18.000+01:00
6ee41da chore(issues): archive closed #1881 SI-16 bencode spec; update EPIC #1669 (Jose Celano) 1293cc3 chore(issues): address Copilot PR review comments on #1886 (Jose Celano) e159b61 chore(issues): promote draft #1885 SI-20 extract-torrust-net-primitives to open; update EPIC #1669 (Jose Celano) 35fd55c chore(issues): add draft spec SI-20 extract-torrust-net-primitives; update EPIC #1669 (Jose Celano) 975b78d chore(issues): promote draft #1884 SI-19 move-bittorrent-peer-id to open; update EPIC #1669 (Jose Celano) 555108e chore(issues): add draft spec for moving bittorrent-peer-id to torrust-bittorrent; update EPIC #1669 (Jose Celano) 8b29e9c chore(issues): promote draft #1882 extract-torrust-metrics to open; update EPIC #1669 (Jose Celano) f34fddc chore(issues): archive closed issue specs #1854, #1864 to docs/issues/closed (Jose Celano) 2717f63 chore: move issue 1879 spec from open to closed (Jose Celano) Pull request description: ## Summary Routine issue spec maintenance on branch `chore/issue-specs-updates`. ### Changes | Commit | Description | |--------|-------------| | `698e00c0` | Move issue #1879 spec from `open/` to `closed/` (PR #1880 merged) | | `69fd8f2c` | Archive closed issue specs #1854 and #1864 to `docs/issues/closed/` | | `a595d38c` | Promote draft #1882 SI-18 (extract torrust-metrics) to `open/`; update EPIC | | `34214084` | Add draft spec for moving `bittorrent-peer-id` to `torrust-bittorrent` | | `f3e405fa` | Promote draft #1884 SI-19 (move bittorrent-peer-id) to `open/`; update EPIC | | `e3af4fb9` | Add draft spec SI-20 for extracting `torrust-net-primitives` to standalone repo | | `a9eff126` | Promote draft #1885 SI-20 (extract torrust-net-primitives) to `open/`; update EPIC | ### New GitHub issues created - [#1882](#1882) — SI-18: Extract `torrust-metrics` to standalone repository - [#1884](#1884) — SI-19: Move `bittorrent-peer-id` to `torrust/torrust-bittorrent` as `torrust-peer-id` - [#1885](#1885) — SI-20: Extract `torrust-net-primitives` to standalone repository ### Related Part of EPIC #1669 — Overhaul: Packages ACKs for top commit: josecelano: ACK 6ee41da Tree-SHA512: 8cb1b18a3712a8110afce92b4fecdca6f5e7e5ba7b741bfb45aaa433e0536d1218e7473fa5de9987f4b5198ddeda0675afcb7e1d819795b74ac649e79db12942
diff --git a/docs/issues/closed/1854-1840-workflow-performance-container-test-gating/ISSUE.md b/docs/issues/closed/1854-1840-workflow-performance-container-test-gating/ISSUE.md
@@ -1,13 +1,13 @@
 ---
 doc-type: issue
 issue-type: task
-status: open
+status: done
 priority: p1
 github-issue: 1854
-spec-path: docs/issues/open/1854-1840-workflow-performance-container-test-gating/ISSUE.md
+spec-path: docs/issues/closed/1854-1840-workflow-performance-container-test-gating/ISSUE.md
 branch: "1854-container-test-gating"
-related-pr: null
-last-updated-utc: 2026-05-27 00:00
+related-pr: 1874
+last-updated-utc: 2026-06-05 00:00
 semantic-links:
   skill-links:
     - create-issue
diff --git a/docs/issues/closed/1854-1840-workflow-performance-container-test-gating/nextest-archive-analysis.md b/docs/issues/closed/1854-1840-workflow-performance-container-test-gating/nextest-archive-analysis.md
diff --git a/docs/issues/closed/1864-1669-review-torrent-peers-limit/ISSUE.md b/docs/issues/closed/1864-1669-review-torrent-peers-limit/ISSUE.md
@@ -1,13 +1,13 @@
 ---
 doc-type: issue
 issue-type: task
-status: open
+status: done
 priority: p3
 github-issue: 1864
-spec-path: docs/issues/open/1864-1669-review-torrent-peers-limit/ISSUE.md
+spec-path: docs/issues/closed/1864-1669-review-torrent-peers-limit/ISSUE.md
 branch: null
-related-pr: null
-last-updated-utc: 2026-06-01 00:00
+related-pr: 1877
+last-updated-utc: 2026-06-05 00:00
 semantic-links:
   skill-links:
     - create-issue
diff --git a/docs/issues/closed/1879-1669-17-extract-torrust-clock-to-standalone-repo.md b/docs/issues/closed/1879-1669-17-extract-torrust-clock-to-standalone-repo.md
@@ -1,18 +1,17 @@
 ---
 doc-type: issue
 issue-type: task
-status: open
+status: done
 priority: p3
 github-issue: 1879
-spec-path: docs/issues/open/1879-1669-17-extract-torrust-clock-to-standalone-repo.md
+spec-path: docs/issues/closed/1879-1669-17-extract-torrust-clock-to-standalone-repo.md
 branch: 1879-1669-extract-torrust-clock-to-standalone-repo
-related-pr: null
+related-pr: 1880
 last-updated-utc: 2026-06-05 00:00
 semantic-links:
   skill-links:
     - create-issue
   related-artifacts:
-    - packages/clock/Cargo.toml
     - Cargo.toml
     - docs/packages.md
     - AGENTS.md
@@ -149,7 +148,7 @@ Status values: `TODO`, `IN_PROGRESS`, `BLOCKED`, `DONE`.
 - 2026-06-05 00:00 UTC - josecelano - T6 deferred: CI, AI agent setup, and release process will be established when the first change to torrust-clock is needed; initial commit pushed to GitHub
 - 2026-06-05 00:00 UTC - josecelano - torrust-clock v3.0.0 published on crates.io; T7–T9 DONE: all 13 consumers migrated to crates.io dep, packages/clock removed from workspace members, directory deleted; M1+M2 verified
 - 2026-06-05 00:00 UTC - josecelano - T10 DONE: AGENTS.md, packages/AGENTS.md, docs/packages.md updated; T13 DONE: EPIC #1669 tables updated; T11+T12 deferred to CI (PR checks)
-- 2026-06-05 00:00 UTC - josecelano - T10 DONE: AGENTS.md, packages/AGENTS.md, docs/packages.md updated; T13 DONE: EPIC #1669 tables updated; T11+T12 deferred to CI (PR #TBD)
+- 2026-06-05 00:00 UTC - josecelano - PR #1880 merged into develop; issue closed; spec moved to docs/issues/closed/
 
 > **Note — deferred setup for `torrust/torrust-clock`**: The following work is intentionally deferred to a future issue opened against the `torrust/torrust-clock` repository, to be done when the first change or publication is needed:
 >
diff --git a/docs/issues/closed/1881-1669-16-migrate-contrib-bencode-to-torrust-bittorrent/ISSUE.md b/docs/issues/closed/1881-1669-16-migrate-contrib-bencode-to-torrust-bittorrent/ISSUE.md
@@ -1,12 +1,12 @@
 ---
 doc-type: issue
 issue-type: task
-status: open
+status: done
 priority: p2
 github-issue: 1881
-spec-path: docs/issues/open/1881-1669-16-migrate-contrib-bencode-to-torrust-bittorrent/ISSUE.md
+spec-path: docs/issues/closed/1881-1669-16-migrate-contrib-bencode-to-torrust-bittorrent/ISSUE.md
 branch: 1881-1669-16-migrate-contrib-bencode-to-torrust-bittorrent
-related-pr: null
+related-pr: 1883
 last-updated-utc: 2026-06-05 00:00
 semantic-links:
   skill-links:
diff --git a/docs/issues/open/1669-overhaul-packages/EPIC.md b/docs/issues/open/1669-overhaul-packages/EPIC.md
diff --git a/docs/issues/open/1882-1669-18-extract-torrust-metrics-to-standalone-repo.md b/docs/issues/open/1882-1669-18-extract-torrust-metrics-to-standalone-repo.md
@@ -1,13 +1,13 @@
 ---
 doc-type: issue
 issue-type: task
-status: draft
+status: open
 priority: p3
-github-issue: null
-spec-path: docs/issues/drafts/1669-extract-torrust-metrics-to-standalone-repo.md
+github-issue: 1882
+spec-path: docs/issues/open/1882-1669-18-extract-torrust-metrics-to-standalone-repo.md
 branch: null
 related-pr: null
-last-updated-utc: 2026-05-15 12:00
+last-updated-utc: 2026-06-05 00:00
 semantic-links:
   skill-links:
     - create-issue
@@ -22,7 +22,7 @@ semantic-links:
 
 <!-- skill-link: create-issue -->
 
-# Issue #[To be assigned] - Extract `torrust-metrics` to a standalone repository
+# Issue #1882 - Extract `torrust-metrics` to a standalone repository
 
 ## Goal
 
@@ -113,12 +113,12 @@ Status values: `TODO`, `IN_PROGRESS`, `BLOCKED`, `DONE`.
 
 ### Workflow Checkpoints
 
-- [ ] Spec drafted in `docs/issues/drafts/`
-- [ ] Spec reviewed and approved by user/maintainer
+- [x] Spec drafted in `docs/issues/drafts/`
+- [x] Spec reviewed and approved by user/maintainer
 - [ ] Metrics rename subissue complete (SI-08; prerequisite)
 - [ ] `torrust-metrics` published on crates.io (T1b; required before extraction)
-- [ ] GitHub issue created and issue number added to this spec
-- [ ] Spec moved to `docs/issues/open/` with issue number prefix
+- [x] GitHub issue created and issue number added to this spec
+- [x] Spec moved to `docs/issues/open/` with issue number prefix
 - [ ] Standalone repository created
 - [ ] Source moved with history preserved
 - [ ] CI set up and passing in new repository
@@ -134,6 +134,7 @@ Status values: `TODO`, `IN_PROGRESS`, `BLOCKED`, `DONE`.
 
 - 2026-05-15 12:00 UTC - josecelano - Spec drafted as subissue of EPIC #1669; follows
   metrics rename subissue
+- 2026-06-05 00:00 UTC - josecelano - GitHub issue #1882 created; spec moved to docs/issues/open/
 
 ## Acceptance Criteria
 
diff --git a/docs/issues/open/1884-1669-19-move-bittorrent-peer-id-to-torrust-bittorrent.md b/docs/issues/open/1884-1669-19-move-bittorrent-peer-id-to-torrust-bittorrent.md
@@ -0,0 +1,162 @@
+---
+doc-type: issue
+issue-type: task
+status: open
+priority: p2
+github-issue: 1884
+spec-path: docs/issues/open/1884-1669-19-move-bittorrent-peer-id-to-torrust-bittorrent.md
+branch: 1884-1669-move-bittorrent-peer-id-to-torrust-bittorrent
+related-pr: null
+last-updated-utc: 2026-06-05 00:00
+semantic-links:
+  skill-links:
+    - create-issue
+  related-artifacts:
+    - packages/peer-id/Cargo.toml
+    - Cargo.toml
+    - packages/http-protocol/Cargo.toml
+    - packages/primitives/Cargo.toml
+    - packages/udp-protocol/Cargo.toml
+    - AGENTS.md
+    - docs/packages.md
+    - docs/issues/open/1669-overhaul-packages/EPIC.md
+---
+
+<!-- skill-link: create-issue -->
+
+# Issue #1884 - Move `packages/peer-id` to `torrust/torrust-bittorrent` as `torrust-peer-id`
+
+## Goal
+
+Rename the crate `bittorrent-peer-id` to `torrust-peer-id`, and move it from the tracker
+workspace (`packages/peer-id`) into `torrust/torrust-bittorrent` (`packages/peer-id`).
+
+## Background
+
+The `packages/peer-id` package is a pure BitTorrent peer-ID parsing and client-identification
+library with no tracker-specific logic. Several facts confirm it is ready for extraction:
+
+- **No workspace dependencies**: its only dependencies are external crates (`compact_str`,
+  `hex`, `quickcheck`, `regex`, `serde`, `zerocopy`). The extraction can proceed without
+  publishing any other workspace package first. _(Verified June 2026.)_
+- **No crates.io publication blockers**: the crate has never been published, so there is no
+  migration window or old-name yank required.
+- **`torrust/torrust-bittorrent` is the agreed destination**: the EPIC #1669 "Desired Package
+  State" table already lists `torrust-peer-id` as an incoming package in that workspace.
+  This is the first package in the `bittorrent-*` extraction sequence.
+- **Three workspace consumers**: `packages/http-protocol`, `packages/primitives`, and
+  `packages/udp-protocol` all depend on `bittorrent-peer-id` via a local path dep. After
+  extraction each dependency becomes a normal crates.io dependency — no other workspace
+  packages change.
+- **Naming alignment**: the `bittorrent-` prefix is a working name carried over from an
+  earlier refactoring cycle. Renaming to `torrust-peer-id` aligns with the `torrust-`
+  organisation prefix adopted for all packages landing in `torrust/torrust-bittorrent`.
+
+This issue is a subissue of EPIC #1669 (Overhaul: Packages).
+
+## Scope
+
+### In Scope
+
+- Rename the crate `name` in `packages/peer-id/Cargo.toml` from `bittorrent-peer-id` to
+  `torrust-peer-id`.
+- Move the crate source to `packages/peer-id` in `torrust/torrust-bittorrent`, preserving
+  relevant history.
+- Update `repository` URL and crate metadata in `Cargo.toml` to point to
+  `https://github.com/torrust/torrust-bittorrent`.
+- Ensure CI passes in the destination repository after migration.
+- Publish `torrust-peer-id` on crates.io from the destination repository.
+- Update the three consumers in the tracker workspace to depend on the published
+  `torrust-peer-id` crate (remove all local path dependencies):
+  - `packages/http-protocol/Cargo.toml`
+  - `packages/primitives/Cargo.toml`
+  - `packages/udp-protocol/Cargo.toml`
+- Remove `packages/peer-id/` from the tracker workspace:
+  - Remove from `members` in the root `Cargo.toml`.
+  - Remove the workspace dependency entry for `bittorrent-peer-id`.
+- Delete `packages/peer-id/` directory from the tracker repo.
+- Update `packages/AGENTS.md`, `AGENTS.md` Package Catalog, and `docs/packages.md`.
+
+### Out of Scope
+
+- Changes to the crate's API or behaviour.
+- Updating other downstream repositories — separate task per repo.
+- Extracting other `bittorrent-*` or `contrib/` crates — each gets its own subissue.
+- Setting up CI from scratch in `torrust/torrust-bittorrent` if it is already in place.
+
+## Implementation Plan
+
+Status values: `TODO`, `IN_PROGRESS`, `BLOCKED`, `DONE`.
+
+| ID  | Status | Task                                                                                                                   | Notes / Expected Output                                                               |
+| --- | ------ | ---------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------- |
+| T1  | TODO   | Rename `name` in `packages/peer-id/Cargo.toml` to `torrust-peer-id`                                                    | `name = "torrust-peer-id"`                                                            |
+| T2  | TODO   | Update `repository` URL in `packages/peer-id/Cargo.toml` and crate metadata                                            | Point to `https://github.com/torrust/torrust-bittorrent`                              |
+| T3  | TODO   | Confirm destination workspace `torrust/torrust-bittorrent` migration path                                              | Target path agreed: `packages/peer-id`                                                |
+| T4  | TODO   | Move/merge crate source into destination workspace, preserving history where practical                                 | `packages/peer-id` added to `torrust/torrust-bittorrent`                              |
+| T5  | TODO   | Set up/adjust CI in destination repository if needed                                                                   | CI green after migration                                                              |
+| T6  | TODO   | Publish `torrust-peer-id` on crates.io from destination repository                                                     | Successful `cargo publish`; crate visible at crates.io/crates/torrust-peer-id         |
+| T7  | TODO   | Update `packages/http-protocol/Cargo.toml`: replace path dep with published `torrust-peer-id`                          | `torrust-peer-id = "X.Y.Z"` (no path)                                                 |
+| T8  | TODO   | Update `packages/primitives/Cargo.toml`: replace path dep with published `torrust-peer-id`                             | `torrust-peer-id = "X.Y.Z"` (no path)                                                 |
+| T9  | TODO   | Update `packages/udp-protocol/Cargo.toml`: replace path dep with published `torrust-peer-id` (keep `zerocopy` feature) | `torrust-peer-id = { version = "X.Y.Z", features = ["zerocopy"] }` (no path)          |
+| T10 | TODO   | Remove `packages/peer-id/` from tracker workspace (`members` + workspace dep in `Cargo.toml`)                          | `cargo build --workspace` succeeds without the local crate                            |
+| T11 | TODO   | Delete `packages/peer-id/` directory from the tracker repo                                                             | Directory gone; workspace still builds                                                |
+| T12 | TODO   | Update `packages/AGENTS.md`, `AGENTS.md`, `docs/packages.md`, and any README references                                | No stale references to `bittorrent-peer-id`                                           |
+| T13 | TODO   | Run `cargo build --workspace`, `cargo test --workspace`, `linter all`                                                  | All green                                                                             |
+| T14 | TODO   | Update EPIC #1669 `Package Inventory` and `Desired Package State` tables                                               | Remove `bittorrent-peer-id` from tracker table; mark as extracted in bittorrent table |
+
+## Progress Tracking
+
+### Workflow Checkpoints
+
+- [x] Spec drafted in `docs/issues/drafts/`
+- [x] Spec reviewed and approved by user/maintainer
+- [x] GitHub issue created and issue number added to this spec
+- [x] Spec moved to `docs/issues/open/` with issue number prefix
+- [ ] Implementation completed
+- [ ] Automatic verification completed (`linter all`, `cargo test --workspace`)
+- [ ] Manual verification scenarios executed and recorded
+- [ ] Acceptance criteria reviewed after implementation and updated with evidence
+- [ ] `torrust-peer-id` published from `torrust/torrust-bittorrent`
+- [ ] EPIC #1669 Active Subissues table updated to `DONE`
+- [ ] Issue closed and spec moved to `docs/issues/closed/`
+
+### Progress Log
+
+- 2026-06-05 00:00 UTC - josecelano - Spec drafted as subissue of EPIC #1669
+- 2026-06-05 00:00 UTC - josecelano - GitHub issue #1884 created; spec promoted to docs/issues/open/
+
+## Acceptance Criteria
+
+- [ ] `packages/peer-id/` directory no longer exists in the tracker workspace.
+- [ ] Root `Cargo.toml` does not list `packages/peer-id` as a workspace member.
+- [ ] No `Cargo.toml` in the tracker workspace references `bittorrent-peer-id`.
+- [ ] `packages/http-protocol/Cargo.toml` depends on the published `torrust-peer-id`.
+- [ ] `packages/primitives/Cargo.toml` depends on the published `torrust-peer-id`.
+- [ ] `packages/udp-protocol/Cargo.toml` depends on the published `torrust-peer-id` with the `zerocopy` feature.
+- [ ] `cargo build --workspace` succeeds without the local peer-id crate.
+- [ ] `cargo test --workspace` passes with zero failures.
+- [ ] `linter all` exits with code `0`.
+- [ ] `torrust-peer-id` is published and visible on crates.io.
+- [ ] Destination repository (`torrust/torrust-bittorrent`) has passing CI and a published release.
+- [ ] `packages/AGENTS.md`, `AGENTS.md`, and `docs/packages.md` no longer list `bittorrent-peer-id`.
+
+## Verification Plan
+
+### Automatic Checks
+
+- `cargo build --workspace`
+- `cargo test --doc --workspace`
+- `cargo test --tests --workspace --all-targets --all-features`
+- `linter all`
+- `cargo machete`
+
+### Manual Verification Scenarios
+
+Status values: `TODO`, `IN_PROGRESS`, `DONE`, `FAILED`, `BLOCKED`.
+
+| ID  | Scenario                                  | Command/Steps                                                                          | Expected Result                         | Status | Evidence |
+| --- | ----------------------------------------- | -------------------------------------------------------------------------------------- | --------------------------------------- | ------ | -------- |
+| M1  | No stale workspace reference to old crate | `grep -r "bittorrent-peer-id\|packages/peer-id" . --include="*.toml" --include="*.rs"` | Zero matches in tracker repo            | TODO   |          |
+| M2  | New crate visible on crates.io            | Visit `https://crates.io/crates/torrust-peer-id`                                       | Crate page exists, latest version shown | TODO   |          |
+| M3  | Destination repository CI green           | Check CI status on `torrust/torrust-bittorrent` default branch                         | All checks pass                         | TODO   |          |
diff --git a/docs/issues/open/1885-1669-20-extract-torrust-net-primitives-to-standalone-repo.md b/docs/issues/open/1885-1669-20-extract-torrust-net-primitives-to-standalone-repo.md
