Commit 9322406
committed
a817386 fix: address Copilot review comments on PR #1883 (Jose Celano)
11b7172 chore(container): remove contrib/bencode from Containerfile (T8) (Jose Celano)
7863546 docs(packages): update EPIC #1669 and ISSUE spec after SI-16 completion (T13) (Jose Celano)
a55c27f chore(packages): remove contrib/bencode and update references (T8-T10) (Jose Celano)
880333e chore: update Cargo.lock after switching to torrust-bencode 3.0.0 (Jose Celano)
a0e0e8e refactor(http-protocol): replace path dep with published torrust-bencode 3.0.0 (Jose Celano)
aaaadc8 docs(packages): open SI-16 #1881 migrate contrib/bencode to torrust-bittorrent (Jose Celano)
Pull request description:
## Summary
Closes #1881 (subissue of EPIC #1669 — Overhaul: Packages)
Migrates the `contrib/bencode` crate (`torrust-tracker-contrib-bencode`) out of this workspace into `torrust/torrust-bittorrent` as the published `torrust-bencode 3.0.0` crate, and removes all traces of it from the tracker workspace.
## Changes
### `torrust/torrust-bittorrent` (already merged — separate repo)
- Renamed crate to `torrust-bencode`, updated metadata and repository URL
- Applied clippy fixes (`ok_or_else`, `map_or`) in `access/convert.rs` and `reference/decode.rs`
- Published `torrust-bencode 3.0.0` to crates.io
### This PR (`torrust/torrust-tracker`)
- **`packages/http-protocol`**: replace path dep `torrust-tracker-contrib-bencode` with published `torrust-bencode = "3.0.0"`; update imports in `announce.rs` and `scrape.rs`
- **`Cargo.lock`**: remove `torrust-tracker-contrib-bencode`, add `torrust-bencode 3.0.0`
- **`contrib/bencode/`**: delete directory (20 files)
- **`AGENTS.md`**: remove bencode from `contrib/` description and Community contributions table
- **`docs/packages.md`**: update `contrib/` tree noting migration
- **`docs/release_process.md`**: remove old crate from publish checklist
- **`src/console/ci/qbittorrent_e2e/bencode.rs`**: update crate name in doc comment
- **`.github/skills/release-new-version/SKILL.md`**: remove `contrib/bencode` version bump step
- **`docs/issues/open/1669-overhaul-packages/EPIC.md`**: mark SI-16 done, update tables
- **`docs/issues/open/1881-.../ISSUE.md`**: mark all tasks done (T1–T11, T13)
## Pending (not in this PR)
- **T12**: Yank `torrust-tracker-contrib-bencode` on crates.io — deferred until no downstream consumers confirmed
## Verification
- `cargo build -p torrust-tracker-http-tracker-protocol` ✅
- `cargo build --workspace` ✅ (verified locally)
- CI will run full suite on this PR
ACKs for top commit:
josecelano:
ACK a817386
Tree-SHA512: e7f3b33c8a2f2ac06a0a9089d3cb6f9b479a5420ddff7dca4ab5f0f7e17b80c9d2a855c7c2c728b0972018ab250ae9db6005d3eae1438bacff9653df4325aab4
33 files changed
Lines changed: 67 additions & 1887 deletions
File tree
- .github
- skills/dev/git-workflow/release-new-version
- workflows
- contrib/bencode
- benches
- src
- access
- mutable
- reference
- tests
- docs
- issues/open
- 1669-overhaul-packages
- 1881-1669-16-migrate-contrib-bencode-to-torrust-bittorrent
- packages/http-protocol
- src/v1/responses
- src/console/ci/qbittorrent_e2e
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
71 | 70 | | |
72 | 71 | | |
73 | 72 | | |
| |||
100 | 99 | | |
101 | 100 | | |
102 | 101 | | |
103 | | - | |
104 | 102 | | |
105 | 103 | | |
106 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
77 | 76 | | |
78 | 77 | | |
79 | 78 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | | - | |
99 | | - | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | 54 | | |
56 | 55 | | |
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
60 | 59 | | |
61 | | - | |
62 | 60 | | |
63 | 61 | | |
64 | 62 | | |
| |||
114 | 112 | | |
115 | 113 | | |
116 | 114 | | |
117 | | - | |
118 | | - | |
119 | 115 | | |
120 | 116 | | |
121 | 117 | | |
| |||
155 | 151 | | |
156 | 152 | | |
157 | 153 | | |
158 | | - | |
159 | | - | |
160 | 154 | | |
161 | 155 | | |
162 | 156 | | |
| |||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
0 commit comments