Skip to content

Commit a817386

Browse files
josecelanojosecelano
committed
fix: address Copilot review comments on PR #1883
- docs/packages.md: restore accurate contrib/ tree (dev-tools still exists) - .github/workflows/deployment.yaml: remove torrust-tracker-contrib-bencode publish step - docs/issues/open/1669-overhaul-packages/EPIC.md: correct yank status to 'yank pending' Part of #1881
1 parent 11b7172 commit a817386

3 files changed

Lines changed: 11 additions & 12 deletions

File tree

‎.github/workflows/deployment.yaml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ jobs:
7373
cargo publish -p torrust-tracker-client
7474
cargo publish -p torrust-clock
7575
cargo publish -p torrust-tracker-configuration
76-
cargo publish -p torrust-tracker-contrib-bencode
7776
cargo publish -p torrust-tracker-events
7877
cargo publish -p torrust-metrics
7978
cargo publish -p torrust-tracker-primitives

‎docs/issues/open/1669-overhaul-packages/EPIC.md‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -687,16 +687,16 @@ dependencies must already be published on crates.io (path deps become version de
687687
extraction). The table below analyses every current or near-term extraction candidate
688688
against this constraint (verified May 2026).
689689

690-
| Package | Crates.io status | Unpublished runtime workspace deps | Can be published independently? | Ordering constraint |
691-
| ----------------------------------------------- | ---------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------- |
692-
| `torrust-tracker-contrib-bencode` | Yes (yanked) | None | ✅ Done (#1881) | Migrated to `torrust/torrust-bittorrent` as `torrust-bencode` 3.0.0; old name yanked (T12 pending) |
693-
| `bittorrent-peer-id` | No | None | ✅ Now | No spec yet; can be extracted first in the `bittorrent-*` sequence |
694-
| `torrust-located-error` | Yes | None | ✅ Already published | No extraction spec yet |
695-
| `torrust-tracker-clock` (→ `torrust-clock`) | Yes | None (✅ `torrust-tracker-primitives` dep removed by SI-02 #1790) | ✅ Extracted (#1879) | Extracted to [torrust/torrust-clock](https://github.com/torrust/torrust-clock); v3.0.0 published on crates.io |
696-
| `torrust-tracker-metrics` (→ `torrust-metrics`) | No | `torrust-tracker-clock` (published ✅; was `torrust-tracker-primitives` — removed by SI-02 #1790) | ✅ After rename | See [extract metrics subissue](../../drafts/1669-extract-torrust-metrics-to-standalone-repo.md) |
697-
| `torrust-tracker-udp-tracker-protocol` | No | `bittorrent-peer-id` (not published) | ❌ | After `bittorrent-peer-id` |
698-
| `torrust-tracker-core` | No | `torrust-tracker-events`, `torrust-tracker-metrics`, `torrust-tracker-swarm-coordination-registry`, `torrust-tracker-rest-api-client` (all unpublished) | ❌ Very deep chain | After all four above; also has `torrust-tracker-rest-api-client` as a runtime dep — a layer violation worth resolving before extraction |
699-
| `torrust-tracker-http-tracker-protocol` | No | `torrust-tracker-core` (unpublished) | ❌ | After `torrust-tracker-core` |
690+
| Package | Crates.io status | Unpublished runtime workspace deps | Can be published independently? | Ordering constraint |
691+
| ----------------------------------------------- | ------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------- |
692+
| `torrust-tracker-contrib-bencode` | Yes (yank pending) | None | ✅ Done (#1881) | Migrated to `torrust/torrust-bittorrent` as `torrust-bencode` 3.0.0; T12 (yank old crate) pending |
693+
| `bittorrent-peer-id` | No | None | ✅ Now | No spec yet; can be extracted first in the `bittorrent-*` sequence |
694+
| `torrust-located-error` | Yes | None | ✅ Already published | No extraction spec yet |
695+
| `torrust-tracker-clock` (→ `torrust-clock`) | Yes | None (✅ `torrust-tracker-primitives` dep removed by SI-02 #1790) | ✅ Extracted (#1879) | Extracted to [torrust/torrust-clock](https://github.com/torrust/torrust-clock); v3.0.0 published on crates.io |
696+
| `torrust-tracker-metrics` (→ `torrust-metrics`) | No | `torrust-tracker-clock` (published ✅; was `torrust-tracker-primitives` — removed by SI-02 #1790) | ✅ After rename | See [extract metrics subissue](../../drafts/1669-extract-torrust-metrics-to-standalone-repo.md) |
697+
| `torrust-tracker-udp-tracker-protocol` | No | `bittorrent-peer-id` (not published) | ❌ | After `bittorrent-peer-id` |
698+
| `torrust-tracker-core` | No | `torrust-tracker-events`, `torrust-tracker-metrics`, `torrust-tracker-swarm-coordination-registry`, `torrust-tracker-rest-api-client` (all unpublished) | ❌ Very deep chain | After all four above; also has `torrust-tracker-rest-api-client` as a runtime dep — a layer violation worth resolving before extraction |
699+
| `torrust-tracker-http-tracker-protocol` | No | `torrust-tracker-core` (unpublished) | ❌ | After `torrust-tracker-core` |
700700

701701
**Practical extraction order for `bittorrent-*` crates** (once decided):
702702

‎docs/packages.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ console/
4646

4747
```output
4848
contrib/
49-
└── (empty — bencode migrated to torrust/torrust-bittorrent as torrust-bencode)
49+
└── dev-tools # Developer tooling (git hooks, container scripts, etc.)
5050
```
5151

5252
## Package Conventions

0 commit comments

Comments
 (0)