Skip to content

Commit ee599dc

Browse files
committed
docs(issues): address Copilot review comments on PR #1702
- project-words.txt: sort newly-appended words alphabetically - 1525-06: fix double semicolon typo in MIGRATOR.run() snippet - 1525-07: replace "reversible" with "tracked as a forward schema change" — sqlx has no down/rollback migrations - 1525-08: fix migration-1 valid_until type (BIGINT → INTEGER to align with other backends; migration-4 widens to BIGINT) - 1525-08: fix Error::migration_error argument order (e, DRIVER) → (DRIVER, e) to match the signature used throughout 1525-06
1 parent de41a57 commit ee599dc

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

docs/issues/1525-06-introduce-schema-migrations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ async fn bootstrap_legacy_schema(pool: &Pool) -> Result<(), Error> {
277277
```rust
278278
async fn create_database_tables(&self) -> Result<(), Error> {
279279
bootstrap_legacy_schema(&self.pool).await?;
280-
MIGRATOR.run(&self.pool).await.map_err(|e| Error::migration_error(DRIVER, e))?;;
280+
MIGRATOR.run(&self.pool).await.map_err(|e| Error::migration_error(DRIVER, e))?;
281281
Ok(())
282282
}
283283
```

docs/issues/1525-07-align-rust-and-db-types.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
Widen the download-counter type in Rust from `u32` to `u64` and widen the corresponding
66
database columns from `INTEGER` (32-bit, MySQL) to `BIGINT` (64-bit), delivered as a versioned
7-
`sqlx` migration so the change is explicit, testable, and reversible.
7+
`sqlx` migration so the change is explicit, testable, and tracked as a forward schema change.
88

99
## Background
1010

docs/issues/1525-08-add-postgresql-driver.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ CREATE TABLE IF NOT EXISTS torrents (
138138
CREATE TABLE IF NOT EXISTS keys (
139139
id SERIAL PRIMARY KEY,
140140
key VARCHAR(32) NOT NULL UNIQUE,
141-
valid_until BIGINT NOT NULL
141+
valid_until INTEGER NOT NULL
142142
);
143143
```
144144

@@ -286,7 +286,7 @@ async fn create_database_tables(&self) -> Result<(), Error> {
286286
MIGRATOR
287287
.run(&self.pool)
288288
.await
289-
.map_err(|e| Error::migration_error(e, DRIVER))?;
289+
.map_err(|e| Error::migration_error(DRIVER, e))?;
290290
Ok(())
291291
}
292292
```

project-words.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -272,13 +272,13 @@ agentskills
272272
frontmatter
273273
MSRV
274274
newtypes
275+
pipefail
276+
qbittorrent
277+
rustup
275278
sqlx
279+
stabilised
276280
subissue
277281
Subissue
278282
Subissues
279-
rustup
280-
pipefail
281-
qbittorrent
282-
stabilised
283283
supertrait
284284
upcasting

0 commit comments

Comments
 (0)