Add new metric label server_binding_address_type#1558
Merged
Conversation
- Label name: `server_binding_address_type`
- Label values: `plain`, `v4_mapped_v6`
Usage example in Prometheous format:
```
udp_tracker_server_requests_accepted_total{request_kind="connect",server_binding_address_type="plain",server_binding_ip="0.0.0.0",server_binding_port="6969",server_binding_protocol="udp"} 1
```
Example of IPv4-mapped-IPv6 IP: `[::ffff:192.0.2.33]`
Member
Author
|
ACK d4c43bd |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1558 +/- ##
===========================================
+ Coverage 83.37% 83.40% +0.03%
===========================================
Files 282 282
Lines 19822 19868 +46
Branches 19822 19868 +46
===========================================
+ Hits 16526 16571 +45
- Misses 3002 3003 +1
Partials 294 294 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new metric label
server_binding_address_type.server_binding_address_typeplain,v4_mapped_v6Usage example in Prometheus format:
Example of IPv4-mapped-IPv6 IP:
[::ffff:192.0.2.33]It should be included whenever another IP label value is used.
cc @devnakx