Skip to content

Commit 4846d95

Browse files
committed
review: address Copilot PR review comments
- Revert blogMetadata.json to develop state (unrelated content reorder) - Add engines field (node >=20.19.0) for updated package requirements - Pin Node version in CI with setup-node action
1 parent 349b116 commit 4846d95

4 files changed

Lines changed: 143 additions & 130 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@ jobs:
1515
- name: Checkout
1616
uses: actions/checkout@v6
1717

18+
- name: Setup Node
19+
uses: actions/setup-node@v4
20+
with:
21+
node-version-file: package.json
22+
1823
- name: Install dependencies
1924
run: npm install
2025

.github/workflows/test.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ jobs:
1212
- name: Checkout
1313
uses: actions/checkout@v6
1414

15+
- name: Setup Node
16+
uses: actions/setup-node@v4
17+
with:
18+
node-version-file: package.json
19+
1520
- name: Enable Package Managers
1621
run: corepack enable
1722

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
"version": "1.0.0",
44
"private": true,
55
"type": "module",
6+
"engines": {
7+
"node": ">=20.19.0"
8+
},
69
"scripts": {
710
"dev": "vite dev",
811
"build": "tsx scripts/generateMetadata.ts && vite build",

0 commit comments

Comments
 (0)