chore(deps): migrate svelte-sitemap from CLI to Vite plugin#208
Merged
Conversation
Member
Author
|
ACK c179bb2 |
There was a problem hiding this comment.
Pull request overview
Migrates sitemap generation in this SvelteKit/Vite codebase from the deprecated svelte-sitemap CLI (npm postbuild hook) to the recommended Vite plugin, so sitemap generation happens during vite build without the deprecation warning.
Changes:
- Register
svelteSitemap({ domain: 'https://torrust.com/' })invite.config.ts. - Remove the
postbuildnpm lifecycle script that invoked the deprecated CLI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vite.config.ts | Adds the svelte-sitemap Vite plugin to generate sitemap.xml as part of the Vite build pipeline. |
| package.json | Removes the deprecated postbuild script that ran the svelte-sitemap CLI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate svelte-sitemap from the deprecated CLI postbuild script to the recommended Vite plugin. This eliminates the deprecation warning on every build.
Changes
svelteSitemap({ domain: 'https://torrust.com/' })plugin tovite.config.tspostbuildscript frompackage.jsonChecklist
npm run lintpassesnpm run checkpassesnpm run buildsucceeds — sitemap now generated viaMethod: Vite plugin(no deprecation warning)