Skip to content

chore: update npm dependencies and contributors list#230

Merged
josecelano merged 2 commits into
torrust:developfrom
josecelano:deps/update-dependabot-deps-june-2026
Jun 26, 2026
Merged

chore: update npm dependencies and contributors list#230
josecelano merged 2 commits into
torrust:developfrom
josecelano:deps/update-dependabot-deps-june-2026

Conversation

@josecelano

@josecelano josecelano commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary

Update npm devDependencies, refresh the contributors list, and address Copilot review feedback.

Changes

Dependency updates

  • @sveltejs/kit: ^2.66.0 → ^2.67.0
  • @types/node: ^25.6.0 → ^26.0.0
  • @typescript-eslint/eslint-plugin: ^8.61.1 → ^8.62.0
  • @typescript-eslint/parser: ^8.61.1 → ^8.62.0
  • globals: ^17.5.0 → ^17.7.0
  • typescript-eslint: ^8.61.1 → ^8.62.0

Contributors

  • Refreshed homepage contributors list from the Torrust GitHub org
  • Updated the script to exclude forked and archived repositories
  • 30 repos processed (46 total, 16 excluded), yielding 42 unique contributors

Review feedback addressed

  • Renamed html_urllogin in defaultContributorsList — the field was storing a GitHub username, not a full URL, which was misleading
  • Updated Contributors.svelte fallback render to use contributor.login instead of contributor.html_url
  • Updated the script to output login instead of html_url
  • Bumped engines.node from >=20.19.0 to >=26.0.0 to match the @types/node v26 upgrade

Checklist

  • npm run lint passes
  • npm run check passes
  • Manually tested in the browser

Updated the following devDependencies:
- @sveltejs/kit: ^2.66.0 → ^2.67.0
- @types/node: ^25.6.0 → ^26.0.0
- @typescript-eslint/eslint-plugin: ^8.61.1 → ^8.62.0
- @typescript-eslint/parser: ^8.61.1 → ^8.62.0
- globals: ^17.5.0 → ^17.7.0
- typescript-eslint: ^8.61.1 → ^8.62.0

Closes dependabot PRs torrust#223, torrust#224, torrust#225, torrust#226, torrust#227
Copilot AI review requested due to automatic review settings June 26, 2026 19:02
@josecelano josecelano self-assigned this Jun 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s npm dependency versions and refreshes the static fallback contributors list used by the website when dynamic contributor loading isn’t available.

Changes:

  • Bumped several devDependencies (SvelteKit, TypeScript ESLint packages, globals, and @types/node) and updated the lockfile accordingly.
  • Refreshed defaultContributorsList to include additional contributors from the Torrust GitHub org.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/lib/constants/constants.ts Extends the static fallback contributors array used for homepage rendering.
package.json Updates devDependency version ranges per the PR summary.
package-lock.json Syncs the lockfile with the updated dependency versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +767 to +770
{
html_url: 'mvanhorn',
avatar_url: 'https://avatars.githubusercontent.com/u/455140?v=4'
},
Comment thread package.json
"@sveltejs/vite-plugin-svelte": "^7.0.0",
"@types/dateformat": "^5.0.3",
"@types/node": "^25.6.0",
"@types/node": "^26.0.0",
@josecelano josecelano force-pushed the deps/update-dependabot-deps-june-2026 branch from a2e082d to 6731786 Compare June 26, 2026 19:16
- Rename html_url field to login in defaultContributorsList (was storing
  a username, not a URL — misleading field name)
- Update the update script to output login instead of html_url
- Update Contributors.svelte fallback render to use contributor.login
- Bump engines.node from >=20.19.0 to >=26.0.0 to match @types/node v26
- Document fork/archive filtering in the update-contributors skill
@josecelano josecelano force-pushed the deps/update-dependabot-deps-june-2026 branch from c555b21 to 4741716 Compare June 26, 2026 20:19
@josecelano

Copy link
Copy Markdown
Member Author

Both Copilot review comments have been addressed:

  1. html_urllogin — Renamed the field in defaultContributorsList, the update script, and the Contributors.svelte fallback render.

  2. @types/node v26 mismatch — Bumped engines.node from >=20.19.0 to >=26.0.0 to match the new @types/node version.

@josecelano

Copy link
Copy Markdown
Member Author

ACK 4741716

@josecelano

Copy link
Copy Markdown
Member Author

Addressed both Copilot review suggestions:

@copilot-pull-request-reviewer — Comment 1 (html_urllogin)
✅ Renamed the field from html_url to login in:

  • defaultContributorsList in constants.ts
  • The update script's output mapping (scripts/updateContributors.ts)
  • The fallback render in Contributors.svelte

The dynamic contributors prop (from the API) still uses the proper Contributor type with both html_url (full URL) and login (username).

@copilot-pull-request-reviewer — Comment 2 (@types/node v26 vs engines.node)
✅ Bumped engines.node from >=20.19.0 to >=26.0.0 in package.json to match the @types/node v26 upgrade.

@josecelano josecelano merged commit 3ee3ae4 into torrust:develop Jun 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants