Skip to content

Commit 43a1173

Browse files
authored
test(core): fix deprecated act() warnings + await expect().rejects (#332)
1 parent 2b6d7a2 commit 43a1173

18 files changed

Lines changed: 190 additions & 169 deletions

File tree

packages/core/src/hooks/useBooleanState/useBooleanState.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ describe('useBooleanState', () => {
2525
const { result } = await renderHookSSR(() => useBooleanState(false));
2626
const [, setTrue] = result.current;
2727

28-
act(() => {
28+
await act(async () => {
2929
setTrue();
3030
});
3131

@@ -37,7 +37,7 @@ describe('useBooleanState', () => {
3737
const { result } = await renderHookSSR(() => useBooleanState(true));
3838
const [, , setFalse] = result.current;
3939

40-
act(() => {
40+
await act(async () => {
4141
setFalse();
4242
});
4343

@@ -49,14 +49,14 @@ describe('useBooleanState', () => {
4949
const { result } = await renderHookSSR(() => useBooleanState(false));
5050
const [, , , toggle] = result.current;
5151

52-
act(() => {
52+
await act(async () => {
5353
toggle();
5454
});
5555

5656
let [bool] = result.current;
5757
expect(bool).toBe(true);
5858

59-
act(() => {
59+
await act(async () => {
6060
toggle();
6161
});
6262

packages/core/src/hooks/useControlledState/useControlledState.spec.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ describe('useControlledState', () => {
1313
expect(value).toBe('testing');
1414
});
1515

16-
it('should be uncontrolled when defaultValue is passed', () => {
16+
it('should be uncontrolled when defaultValue is passed', async () => {
1717
const { result } = renderHookSSR(() => useControlledState({ defaultValue: 'testing' }));
1818
const [value] = result.current;
1919
expect(value).toBe('testing');
2020

21-
act(() => {
21+
await act(async () => {
2222
const [, setValue] = result.current;
2323
setValue('naruto');
2424
});
@@ -27,12 +27,12 @@ describe('useControlledState', () => {
2727
expect(next).toBe('naruto');
2828
});
2929

30-
it('should be controlled when value is passed', () => {
30+
it('should be controlled when value is passed', async () => {
3131
const { result } = renderHookSSR(() => useControlledState({ value: 'testing' }));
3232
const [value] = result.current;
3333
expect(value).toBe('testing');
3434

35-
act(() => {
35+
await act(async () => {
3636
const [, setValue] = result.current;
3737
setValue('naruto');
3838
});
@@ -71,12 +71,12 @@ describe('useControlledState', () => {
7171
expect(screen.getByTestId('value')).toHaveTextContent('0');
7272
});
7373

74-
it('should not change when the value is the same', () => {
74+
it('should not change when the value is the same', async () => {
7575
const { result } = renderHookSSR(() => useControlledState({ value: 'testing' }));
7676
const [value] = result.current;
7777
expect(value).toBe('testing');
7878

79-
act(() => {
79+
await act(async () => {
8080
const [, setValue] = result.current;
8181
setValue('testing');
8282
});
@@ -85,15 +85,15 @@ describe('useControlledState', () => {
8585
expect(next).toBe('testing');
8686
});
8787

88-
it('should handle controlled undefined value correctly', () => {
88+
it('should handle controlled undefined value correctly', async () => {
8989
const { result } = renderHookSSR(() =>
9090
useControlledState({
9191
value: 'test',
9292
onChange: () => {},
9393
})
9494
);
9595

96-
act(() => {
96+
await act(async () => {
9797
const [, setValue] = result.current;
9898
setValue(undefined as never);
9999
});
@@ -102,12 +102,12 @@ describe('useControlledState', () => {
102102
expect(value).toBe('test');
103103
});
104104

105-
it('should handle function setState action', () => {
105+
it('should handle function setState action', async () => {
106106
const { result } = renderHookSSR(() => useControlledState({ defaultValue: 5 }));
107107
const [value] = result.current;
108108
expect(value).toBe(5);
109109

110-
act(() => {
110+
await act(async () => {
111111
const [, setValue] = result.current;
112112
setValue(prev => prev + 3);
113113
});

packages/core/src/hooks/useCounter/useCounter.spec.ts

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -16,51 +16,51 @@ describe('useCounter', () => {
1616
expect(result.current.count).toBe(10);
1717
});
1818

19-
it('should increment the counter', () => {
19+
it('should increment the counter', async () => {
2020
const { result } = renderHook(() => useCounter(5));
2121

22-
act(() => {
22+
await act(async () => {
2323
result.current.increment();
2424
});
2525

2626
expect(result.current.count).toBe(6);
2727
});
2828

29-
it('should decrement the counter', () => {
29+
it('should decrement the counter', async () => {
3030
const { result } = renderHook(() => useCounter(5));
3131

32-
act(() => {
32+
await act(async () => {
3333
result.current.decrement();
3434
});
3535

3636
expect(result.current.count).toBe(4);
3737
});
3838

39-
it('should reset the counter to initial value', () => {
39+
it('should reset the counter to initial value', async () => {
4040
const { result } = renderHook(() => useCounter(5));
4141

42-
act(() => {
42+
await act(async () => {
4343
result.current.increment();
4444
result.current.increment();
4545
});
4646

4747
expect(result.current.count).toBe(7);
4848

49-
act(() => {
49+
await act(async () => {
5050
result.current.reset();
5151
});
5252

5353
expect(result.current.count).toBe(5);
5454
});
5555

56-
it('should not go below minimum value', () => {
56+
it('should not go below minimum value', async () => {
5757
const { result } = renderHook(() =>
5858
useCounter(5, {
5959
min: 3,
6060
})
6161
);
6262

63-
act(() => {
63+
await act(async () => {
6464
result.current.decrement();
6565
result.current.decrement();
6666
result.current.decrement();
@@ -69,14 +69,14 @@ describe('useCounter', () => {
6969
expect(result.current.count).toBe(3);
7070
});
7171

72-
it('should not go above maximum value', () => {
72+
it('should not go above maximum value', async () => {
7373
const { result } = renderHook(() =>
7474
useCounter(5, {
7575
max: 7,
7676
})
7777
);
7878

79-
act(() => {
79+
await act(async () => {
8080
result.current.increment();
8181
result.current.increment();
8282
result.current.increment();
@@ -85,20 +85,20 @@ describe('useCounter', () => {
8585
expect(result.current.count).toBe(7);
8686
});
8787

88-
it('should use the provided step value for increment and decrement', () => {
88+
it('should use the provided step value for increment and decrement', async () => {
8989
const { result } = renderHook(() =>
9090
useCounter(5, {
9191
step: 2,
9292
})
9393
);
9494

95-
act(() => {
95+
await act(async () => {
9696
result.current.increment();
9797
});
9898

9999
expect(result.current.count).toBe(7);
100100

101-
act(() => {
101+
await act(async () => {
102102
result.current.decrement();
103103
});
104104

@@ -123,37 +123,37 @@ describe('useCounter', () => {
123123
expect(result2.current.count).toBe(8);
124124
});
125125

126-
it('should allow setting arbitrary value within constraints', () => {
126+
it('should allow setting arbitrary value within constraints', async () => {
127127
const { result } = renderHook(() =>
128128
useCounter(0, {
129129
min: 3,
130130
max: 8,
131131
})
132132
);
133133

134-
act(() => {
134+
await act(async () => {
135135
result.current.setCount(6);
136136
});
137137

138138
expect(result.current.count).toBe(6);
139139

140-
act(() => {
140+
await act(async () => {
141141
result.current.setCount(1);
142142
});
143143

144144
expect(result.current.count).toBe(3);
145145

146-
act(() => {
146+
await act(async () => {
147147
result.current.setCount(10);
148148
});
149149

150150
expect(result.current.count).toBe(8);
151151
});
152152

153-
it('should work with updater function for setCount', () => {
153+
it('should work with updater function for setCount', async () => {
154154
const { result } = renderHook(() => useCounter(5));
155155

156-
act(() => {
156+
await act(async () => {
157157
result.current.setCount(prev => prev + 3);
158158
});
159159

0 commit comments

Comments
 (0)