docs: update code example and some contents#195
Merged
Conversation
jsparkdev
requested review from
choi2021,
pumpkiinbell and
seungrodotlee
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the introductory documentation in both English and Korean to improve clarity and consistency. Key changes include:
- Adding missing inline code formatting around "react-simplikit".
- Renaming the state update function from setOpen to setIsOpen.
- Updating the Korean translation for a more natural tone.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/docs/ko/intro.md | Updated code sample naming and refined translation. |
| src/docs/en/intro.md | Updated inline code formatting and naming convention. |
Contributor
seungrodotlee
left a comment
seungrodotlee
left a comment
There was a problem hiding this comment.
How about keep setOpen?
Contributor
Author
|
Thanks for good review. I've fixed it to be consistent with the state names used on other page. If this was the intent, I'll leave |
Contributor
|
Oh, I missed that — thanks for pointing it out. Would you mind unifying the naming style in this PR accordingly? |
jsparkdev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Checklist
yarn test:coverageto make sure there is no uncovered line?