Skip to content

style: update background colors of codeblocks#198

Merged
seungrodotlee merged 3 commits into
toss:mainfrom
jsparkdev:contributing
Apr 24, 2025
Merged

style: update background colors of codeblocks#198
seungrodotlee merged 3 commits into
toss:mainfrom
jsparkdev:contributing

Conversation

@jsparkdev
Copy link
Copy Markdown
Contributor

@jsparkdev jsparkdev commented Apr 19, 2025

Overview

  • update the background color of codeblocks to improve readability.
  • add missing inline code.

codeblock background

before

스크린샷 2025-04-19 오후 4 17 41

after

스크린샷 2025-04-19 오후 4 21 30

Checklist

  • Did you write the test code?
  • Have you run yarn test:coverage to make sure there is no uncovered line?
  • Did you write the JSDoc?

Copilot AI review requested due to automatic review settings April 19, 2025 07:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the contributing documentation in both Korean and English to improve the readability of code blocks and to include missing inline code.

  • Updated the background color in code block examples from white to #161618.
  • Adjusted inline code formatting for branch references.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/docs/ko/contributing.md Updated code block background color to improve readability.
src/docs/en/contributing.md Updated code block background color and formatted the branch name inline.

Copy link
Copy Markdown
Contributor

@seungrodotlee seungrodotlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sould consider both light and dark theme.

@jsparkdev jsparkdev changed the title docs(contributing): update Korean and English documents style: update background colors of codeblocks Apr 24, 2025
Copy link
Copy Markdown
Contributor

@seungrodotlee seungrodotlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@seungrodotlee seungrodotlee merged commit 7087367 into toss:main Apr 24, 2025
8 checks passed
@jsparkdev jsparkdev deleted the contributing branch April 24, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants