refactor(useCounter): modify useCounter props structure#222
Merged
seungrodotlee merged 2 commits intoMay 7, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 33
Lines 839 839
Branches 254 254
=========================================
Hits 839 839 🚀 New features to boost your workflow:
|
f5271ed to
f18c5a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Refactor: Change Parameter Structure of useCounter Hook
Improved the API of the
useCounterhook to make it more intuitive and easier to use. Previously, all settings were inside an options object, but now the most frequently usedinitialValueparameter has been separated as the first argument.Before:
After:
Refactoring Reasons:
useState,useReducer, etc.) follow the pattern of receiving initial values as the first argument. This change aligns with common conventions in the React ecosystem.This change is purely for API structure improvement, with no functional changes.
Checklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?