fix: Apply forwardRef to ImpressionArea#241
Merged
Merged
Conversation
jungpaeng
requested review from
choi2021,
pumpkiinbell and
seungrodotlee
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request applies a fix to the ImpressionArea component by wrapping it in forwardRef to support older versions of React that require it for ref forwarding.
- Updated the ImpressionArea implementation to use forwardRef with an arrow function.
- Ensured the component's display name is set for easier debugging.
| export const ImpressionArea = forwardRef( | ||
| <T extends ElementType = 'div'>( | ||
| { as, rootMargin, areaThreshold, timeThreshold, onImpressionStart, onImpressionEnd, ...props }: Props<T>, | ||
| ref: React.Ref<Element> |
There was a problem hiding this comment.
Consider using React.Ref instead of React.Ref for improved type safety, since the component's ref is expected to reference an HTMLElement.
Contributor
|
Size Change: +230 B (+0.43%) Total Size: 54.1 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 33
Lines 839 836 -3
Branches 254 254
=========================================
- Hits 839 836 -3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
In React versions below 18, it is not possible to pass a ref without using forwardRef.
Checklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?