feat(core/hooks): add 'useSet' hook#339
Merged
Merged
Conversation
kimyouknow
approved these changes
Mar 13, 2026
Collaborator
kimyouknow
left a comment
There was a problem hiding this comment.
Thanks for addition! useSet mirrors useMap nicely.
kimyouknow
reviewed
Mar 13, 2026
Comment on lines
+66
to
+76
| const toggle = usePreservedCallback((value: T) => { | ||
| setSet(prev => { | ||
| const nextSet = new Set(prev); | ||
| if (nextSet.has(value)) { | ||
| nextSet.delete(value); | ||
| } else { | ||
| nextSet.add(value); | ||
| } | ||
| return nextSet; | ||
| }); | ||
| }); |
Collaborator
There was a problem hiding this comment.
One suggestion: the toggle implementation uses if/else — an early
return pattern would be cleaner:
const toggle = usePreservedCallback((value: T) => {
setSet(prev => {
const nextSet = new Set(prev);
if (nextSet.has(value)) {
nextSet.delete(value);
return nextSet;
}
nextSet.add(value);
return nextSet;
});
});Non-blocking — approved. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add
useSethook that manages a Set as state, mirroring theuseMappattern.add/removefor adding and removing valuestoggleadds the value if absent, removes it if presentsetAllreplaces all values in the setresetrestores the set to its initial stateSet<T>orT[]as initial stateusePreservedCallbackChecklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?