Update codesniffer ruleset

Author: angelakuznetsova

src/Standards/Totara/ruleset.xml

@@ -68,8 +68,6 @@
     <rule ref="Generic.Classes.OpeningBraceSameLine"/>
     <rule ref="Totara.NamingConventions.ValidClassName"/>
 
-    <!-- Removed in PHPCS 4: Squiz.CSS.* class brace spacing sniffs. -->
-
     <!-- When instantiating a new class, parenthesis MUST always be present even when there are no arguments passed to the constructor. -->
     <rule ref="PSR12.Classes.ClassInstantiation"/>
 
@@ -87,7 +85,43 @@
 
     <!-- 4.4 Methods/Functions -->
 
-    <!-- TODO Add spacing rules for function calls and declarations -->
+    <!-- Spacing rules for function calls and declarations -->
+
+    <!-- No space between function name and opening parenthesis in calls -->
+    <rule ref="Generic.Functions.FunctionCallArgumentSpacing"/>
+
+    <!-- Space after comma in function arguments -->
+    <rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing">
+        <properties>
+            <property name="equalsSpacing" value="1"/>
+        </properties>
+    </rule>
+
+    <!-- No space before semicolons -->
+    <rule ref="Squiz.WhiteSpace.SemicolonSpacing"/>
+
+    <!-- No space around cast operators -->
+    <rule ref="Generic.Formatting.SpaceAfterCast"/>
+
+    <!-- No space between function name and opening parenthesis -->
+    <rule ref="Squiz.Functions.FunctionDeclaration"/>
+
+    <!-- Space before/after function declaration -->
+    <rule ref="Squiz.WhiteSpace.FunctionSpacing">
+        <properties>
+            <property name="spacing" value="1"/>
+            <property name="spacingBeforeFirst" value="0"/>
+            <property name="spacingAfterLast" value="0"/>
+        </properties>
+    </rule>
+
+    <!-- Correct spacing around operator in default parameter value -->
+    <rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceBeforeEquals">
+        <severity>0</severity>
+    </rule>
+    <rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing.SpaceAfterEquals">
+        <severity>0</severity>
+    </rule>
 
     <!-- Visibility MUST be declared on all methods. -->
     <rule ref="Squiz.Scope.MethodScope"/>
@@ -197,91 +231,65 @@
             <property name="absoluteNestingLevel" value="10"/>
         </properties>
     </rule>
-    <rule ref="Generic.Metrics.CyclomaticComplexity">
-        <!-- php:S3776 Cognitive/cyclomatic complexity -->
-        <properties>
-            <property name="complexity" value="15"/>
-            <property name="absoluteComplexity" value="30"/>
-        </properties>
-    </rule>
 
-    <!-- SonarQube rule coverage (php:S1068, php:S1172) -->
     <!-- Unused parameters -->
     <rule ref="Generic.CodeAnalysis.UnusedFunctionParameter"/>
 
-    <!-- SonarQube rule coverage (php:S1116) -->
     <!-- Empty PHP statements (;;) -->
     <rule ref="Generic.CodeAnalysis.EmptyPHPStatement"/>
 
-    <!-- SonarQube rule coverage (php:S1186, php:S905) -->
     <!-- Empty catch/if/else bodies -->
     <rule ref="Generic.CodeAnalysis.EmptyStatement"/>
 
-    <!-- SonarQube rule coverage (php:S1121) -->
     <!-- Assignment in condition -->
     <rule ref="Generic.CodeAnalysis.AssignmentInCondition"/>
 
-    <!-- SonarQube rule coverage (php:S1145) -->
     <!-- if (true) / if (false) unconditional -->
     <rule ref="Generic.CodeAnalysis.UnconditionalIfStatement"/>
 
-    <!-- SonarQube rule coverage (php:S1185) -->
     <!-- Useless overriding methods that just call parent -->
     <rule ref="Generic.CodeAnalysis.UselessOverridingMethod"/>
 
-    <!-- SonarQube rule coverage (php:S1110) -->
     <!-- Unnecessary parentheses -->
     <rule ref="Generic.WhiteSpace.ArbitraryParenthesesSpacing"/>
 
-    <!-- SonarQube rule coverage (php:S1134) -->
     <!-- FIXME comments -->
     <rule ref="Generic.Commenting.Fixme"/>
 
-    <!-- SonarQube rule coverage (php:S1135) -->
     <!-- TODO comments -->
     <rule ref="Generic.Commenting.Todo"/>
 
-    <!-- SonarQube rule coverage (php:S125) -->
     <!-- Commented-out code -->
     <rule ref="Squiz.PHP.CommentedOutCode">
         <properties>
             <property name="maxPercentage" value="35"/>
         </properties>
     </rule>
 
-    <!-- SonarQube rule coverage (php:S1763, php:S881) -->
     <!-- Dead/non-executable code after return/throw/etc -->
     <rule ref="Squiz.PHP.NonExecutableCode"/>
 
-    <!-- SonarQube rule coverage (php:S139) -->
     <!-- Inline comments after statements -->
     <rule ref="Squiz.Commenting.PostStatementComment"/>
 
-    <!-- SonarQube rule coverage (php:S1788) -->
     <!-- Default parameter values must not follow non-default params -->
     <rule ref="PEAR.Functions.ValidDefaultValue"/>
 
-    <!-- SonarQube rule coverage (php:S907) -->
     <!-- Discourage goto -->
     <rule ref="Generic.PHP.DiscourageGoto"/>
 
-    <!-- SonarQube rule coverage (php:S2068) -->
-    <!-- No hardcoded credentials / passwords in code -->
+    <!-- Forbidden/dangerous functions (e.g. eval, var_dump, sizeof → configure as needed) -->
     <rule ref="Generic.PHP.ForbiddenFunctions"/>
 
-    <!-- SonarQube rule coverage (php:S1192) -->
     <!-- Unnecessary string concatenation -->
     <rule ref="Generic.Strings.UnnecessaryStringConcat"/>
 
-    <!-- SonarQube rule coverage (php:S1301) -->
-    <!-- Single-case switch statements -->
+    <!-- Jumbled loop incrementers (e.g. same variable in nested for-loops) -->
     <rule ref="Generic.CodeAnalysis.JumbledIncrementer"/>
 
-    <!-- SonarQube rule coverage (php:S1155, php:S3699) -->
     <!-- Duplicate class names -->
     <rule ref="Generic.Classes.DuplicateClassName"/>
 
-    <!-- SonarQube rule coverage (php:S2612) -->
     <!-- No silenced errors (@) -->
     <rule ref="Generic.PHP.NoSilencedErrors"/>