🔒 fix(ci): split release workflow for proper credential scoping#158
Merged
Conversation
The post-release PR step failed because persist-credentials was set to false (added by zizmor audit) but the step needed git push access via RELEASE_TOKEN. Split publish and post-release into separate jobs so credentials are only persisted where git push is needed, and the RELEASE_TOKEN is scoped to the release environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-release PR step in the release workflow fails with
fatal: could not read Usernamebecausepersist-credentials: falsewas added by the zizmor security audit (#154), but the step needsgit pushaccess viaRELEASE_TOKEN.The fix splits the release workflow into two jobs. The
publishjob keepspersist-credentials: falsesince it only needs to build and publish — no git push. Thepost-releasejob also usespersist-credentials: falsebut configures git auth viaremote set-urlscoped to the single step that needs push access, withRELEASE_TOKENprotected by thereleaseenvironment.The changelog patching is replicated in the post-release job so the version bump PR includes the updated
CHANGELOG.md, matching the original behavior.