♻️ refactor: use public PluginManager.isPluginInstalled#188
Merged
Conversation
PluginManagerCore.getPlugin(PluginId) is @ApiStatus.Internal. The public PluginManager.isPluginInstalled(PluginId) combined with the existing isDisabled check is behavior-preserving (installed and enabled), and drops the one internal-API usage the platform offers a public alternative for. The uv/venv SDK flavor, icon, and additional-data APIs stay as-is since they have no public alternative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin-availability check called
PluginManagerCore.getPlugin(PluginId), which is@ApiStatus.Internalon 262 and surfaced as an internal-API usage in the verifier report. Unlike the uv/venv SDK flavor, icon, and additional-data APIs (which are internal with no public alternative), this one has a public escape hatch:com.intellij.ide.plugins.PluginManager.isPluginInstalled(PluginId).Swapping to it keeps the behavior identical.
isPluginInstalledreports presence regardless of enablement, and the existingPluginManagerCore.isDisabledguard (which the verifier does not flag as internal) still narrows the result to installed-and-enabled. The check also reads more clearly now that the two plugin IDs share a small helper.Also bumps the dev version to
2.4.1-dev, superseding the automated #187.🤖 Generated with Claude Code