serialise singleton construction in FileLockMeta#581
Merged
Conversation
Collapse the eight-argument construction call that _create_instance duplicated at both call sites into a single params dict built once in __call__, so the helper drops its PLR0913 signature down to three parameters. Fix the codespell failure (serialise) and tighten the serialisation comment.
Contributor
Author
|
TY! |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileLockMeta.call reads and writes its singleton cache without a lock, so two threads constructing the same is_singleton=True lock for a fresh path both miss the cache and each build their own instance. That quietly breaks the singleton guarantee callers lean on for reentrant locking across instances, so a later reentrant acquire on what should be the same lock can hit the deadlock check in acquire(), and the concurrent writes to the shared WeakValueDictionary are a race in their own right. ReadWriteLock and SoftReadWriteLock already take their _instances_lock around the get-or-create, so this brings the base metaclass in line.