Basic gameserver starting implementation

Author: Heliodex

Site/src/routes/(main)/place/[id=asset]/[name]/+page.server.ts

@@ -2,7 +2,8 @@ import { error, redirect } from "@sveltejs/kit"
 import { authorise } from "$lib/server/auth"
 import config from "$lib/server/config"
 import formData from "$lib/server/formData"
-import { getGameserver } from "$lib/server/orbiter"
+import { getGameserver, startGameserver } from "$lib/server/orbiter"
+import ratelimit from "$lib/server/ratelimit"
 import { db, findWhere, Record } from "$lib/server/surreal"
 import { couldMatch, encode } from "$lib/urlName"
 import findPlaceQuery from "./findPlace.surql"
@@ -83,13 +84,10 @@ export async function load({ locals, params, url }) {
 	}
 }
 
-export const actions: import("./$types").Actions = {}
-actions.join = async ({ locals, params, request }) => {
-	const { user } = await authorise(locals)
+async function findPlace(request: Request, id: number, user: User) {
 	const data = await formData(request)
 	const privateTicket = data?.privateTicket
 
-	const id = +params.id
 	const placeR = Record("place", id)
 	const [[place]] = await db.query<FoundPlace[][]>(findPlaceQuery, {
 		place: placeR,
@@ -103,13 +101,27 @@ actions.join = async ({ locals, params, request }) => {
 	)
 		error(404, "Place not found")
 
+	return placeR
+}
+
+async function checkUser(locals: App.Locals) {
+	const { user } = await authorise(locals)
+
 	const foundModerated = await findWhere(
 		"moderation",
 		"out = $user AND active = true",
 		{ user: Record("user", user.id) }
 	)
 	if (foundModerated) error(403, "You cannot currently play games")
 
+	return user
+}
+
+export const actions: import("./$types").Actions = {}
+actions.join = async ({ locals, params, request }) => {
+	const user = await checkUser(locals)
+	const placeR = await findPlace(request, +params.id, user)
+
 	// Invalidate all game sessions and create valid playing
 	const [, [ticket]] = await db.query<string[][]>(invalidatePlayingQuery, {
 		user: Record("user", user.id),
@@ -118,3 +130,21 @@ actions.join = async ({ locals, params, request }) => {
 
 	return { ticket }
 }
+
+actions.start = async ({ locals, params, getClientAddress }) => {
+	await checkUser(locals)
+
+	const limit = ratelimit(null, "serverstart", getClientAddress, 20)
+	if (limit) return limit
+
+	const id = +params.id
+	const res = await startGameserver(id)
+	if (!res.ok) {
+		console.error(
+			"Failed to start dedicated gameserver for id",
+			id,
+			res.msg
+		)
+		error(500, "Failed to start dedicated server")
+	}
+}

Site/src/routes/(main)/place/[id=asset]/[name]/+page.svelte

@@ -18,6 +18,7 @@
 
 	let place = $state(data.place)
 	let online = $derived(place.serverPing > Date.now() / 1000 - 35)
+	let currentPath = $derived(`/place/${place.id}/${data.slug}`)
 
 	const statistics = $derived([
 		// ["Activity", "0 visits"],
@@ -33,35 +34,42 @@
 	let installed = $state(true)
 	let success = $state(false)
 
-	const launch = (joinscripturl: () => string) => () => {
-		success = false
-		customProtocol(
-			joinscripturl(),
-			() => {
-				success = true
-				setTimeout(() => popover?.hidePopover(), 16000)
-			},
-			() => {
-				installed = false
-			}
-		)
+	function privateFetch() {
+		const body = new FormData()
+		body.append("privateTicket", place.privateTicket)
+		return { method: "POST", body }
 	}
 
+	// we don't want to start a server if the user is just opening studio to edit the place
+	const launch =
+		(joinscripturl: () => string, startServer = false) =>
+		() => {
+			success = false
+			customProtocol(
+				joinscripturl(),
+				async () => {
+					// this isn't a guarantee that the game has succeeded in launching, but it's a decent guess I guess??
+					if (startServer)
+						await fetch(`${currentPath}?/start`, privateFetch())
+
+					success = true
+					setTimeout(() => popover?.hidePopover(), 16000)
+				},
+				() => {
+					installed = false
+				}
+			)
+		}
+
 	let loadCommand = $derived(
 		`dofile "http://${data.domain}/game/host?ticket=${place.serverTicket}"`
 	)
 
 	async function placeLauncher() {
 		installed = true
 
-		const formdata = new FormData()
-		formdata.append("privateTicket", place.privateTicket)
-
 		// Get the joinscript URL
-		const response = await fetch(`/place/${place.id}/${data.slug}?/join`, {
-			method: "POST",
-			body: formdata
-		})
+		const response = await fetch(`${currentPath}?/join`, privateFetch())
 		const joinScriptData = deserialize(await response.text()) as {
 			status: number
 			data: { ticket: string }
@@ -70,7 +78,7 @@
 
 		// JoinScript is my favourite programming language (-i mean scripting language)
 		const joinUri = data.scheme + joinScriptData.data.ticket
-		launch(() => joinUri)()
+		launch(() => joinUri, true)()
 	}
 
 	const tabs = ["Description", "Servers"]

Site/src/routes/(rbxclient)/game/join/+server.ts

@@ -25,10 +25,6 @@ export async function GET({ url }) {
 
 	if (!clientTicket) error(400, "Invalid Request")
 
-	const playing = Record("playing", clientTicket)
-	const [[gameSession]] = await db.query<Session[][]>(joinQuery, { playing })
-	if (!gameSession) error(400, "Invalid Game Session")
-
 	const foundPrivatePlace = await findWhere(
 		"place",
 		"privateTicket = $privateServer",
@@ -37,7 +33,10 @@ export async function GET({ url }) {
 	if (privateServer && !foundPrivatePlace)
 		error(400, "Invalid Private Server")
 
-	await db.merge(playing, { valid: false })
+	const playing = Record("playing", clientTicket)
+	// also invalidates the session
+	const [gameSession] = await db.query<Session[]>(joinQuery, { playing })
+	if (!gameSession) error(400, "Invalid Game Session")
 
 	const placeId = gameSession.place.id
 	const creatorUsername = gameSession.place.ownerUser?.username

Site/src/routes/(rbxclient)/game/join/join.surql

@@ -7,4 +7,6 @@ SELECT
 	FROM ->place)[0] AS place,
 	(SELECT permissionLevel, username
 	FROM <-user)[0] AS user
-FROM $playing;
+FROM ONLY $playing;
+
+UPDATE $playing SET valid = false;