Merge main into ledgertests#453
Merged
Merged
Conversation
…ged in users on about page
thanks meditext
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs changes from main into the ledgertests branch and introduces a new /about page in the Site app, along with related UI and dependency updates.
Changes:
- Added a new
(legal)/aboutroute with multiple Svelte components (screenshots, animated sections, SVG padlock, optional 3D cubes experiment). - Updated server-side image processing helpers to use
Bun.Imagefor several asset types. - Updated dependencies/lockfile and added an “About” link to the site footer.
Reviewed changes
Copilot reviewed 11 out of 19 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Site/src/routes/(main)/user/[username]/+page.svelte | Tweaks profile dropdown + description rendering. |
| Site/src/routes/(legal)/about/+page.svelte | New About page content + scroll controls and optional interactive section. |
| Site/src/routes/(legal)/about/Cube.svelte | New Threlte cube component for the About page experiment. |
| Site/src/routes/(legal)/about/Cubes.svelte | New Threlte scene wrapper for rendering cube grid. |
| Site/src/routes/(legal)/about/Libraries.svelte | New animated “libraries usage” screenshot layout. |
| Site/src/routes/(legal)/about/Padlock.svelte | New SVG padlock/logo animation. |
| Site/src/routes/(legal)/about/Pagepart.svelte | New wrapper component for in-view + fly-in page sections. |
| Site/src/routes/(legal)/about/Screenshots.svelte | New animated screenshots layout. |
| Site/src/lib/server/imageAsset.ts | Switches some image resizing/encoding flows from Sharp to Bun.Image. |
| Site/src/components/Footer.svelte | Adds an “About” link in the footer. |
| Site/package.json | Dependency bumps + adds Threlte and svelte-inview. |
| Site/bun.lock | Lockfile updates for dependency changes. |
Comments suppressed due to low confidence (3)
Site/src/lib/server/imageAsset.ts:7
- The JSDoc for
imageAssetstill documents asharpOptionsparameter, but the function signature no longer accepts it (and the implementation now usesBun.Image). Please update the JSDoc to match the current API.
/**
* Creates an image asset based off a file object
* @param file A File object for the image to save
* @param sharpOptions Extra options to pass to sharp
* @returns A function that saves the image to ../data/assets
Site/src/lib/server/imageAsset.ts:30
- The JSDoc for
clothingAssetstill mentions asharpOptionsparameter, but the function no longer accepts it. Please update/remove that parameter description so the doc matches the current API.
/**
* Creates a clothing asset based off a file object
* @param file A File object for the image to save
* @param sharpOptions Extra options to pass to sharp
* @returns A function that saves the image to ../data/assets
Site/src/lib/server/imageAsset.ts:51
- The JSDoc for
thumbnailstill documents asharpOptionsparameter, but the function signature no longer accepts it. Please update the doc comment to avoid misleading callers.
/**
* Creates an image thumbnail based off a file object
* @param b An ArrayBuffer for the image to save
* @param sharpOptions Extra options to pass to sharp
* @returns A function that saves the image to data/assets
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+117
to
119
| b1<ReportButton | ||
| user={data.username} | ||
| url="/user/{data.username}" /> |
| <div class="dropdown-content pt-2"> | ||
| <ul class="p-2 rounded-3"> | ||
| <ReportButton | ||
| b2<ReportButton |
Comment on lines
+113
to
+115
| 0% { | ||
| transform: translate(-158px, 118px) scale(-1.03, 1); | ||
| } |
Comment on lines
+119
to
+124
| <button | ||
| class="btn light-text left-1/2 text-3rem z-3" | ||
| aria-label="Scroll down" | ||
| onclick={downScroll} | ||
| onkeypress={downScroll} | ||
| style="opacity: {(500 - scrollY) / 300}"> |
Comment on lines
+128
to
+133
| <button | ||
| class="btn light-text fixed pb-4 bottom-0 right-0 z-10 text-2rem" | ||
| aria-label="Scroll up" | ||
| onclick={upScroll} | ||
| onkeypress={upScroll} | ||
| style="opacity: {(scrollY - 500) / 300}"> |
|
|
||
| const opacity = new Spring(0) | ||
| $effect(() => { | ||
| opacity.set(Math.random() + (-j - i / 2 - 5) / 12) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepare for actual ledger integration with site O_O