Fix warnings

Author: tpayne

.travis.yml

@@ -1,3 +1,3 @@
 language: java
 sudo: false
-script: mvn clean compile -Dmaven.test.skip=true
+script: mvn clean verify  -Dmaven.test.skip=true

devops-framework-core/src/main/groovy/org/devops/framework/core/ComponentManifest.groovy

@@ -10,15 +10,6 @@ class ComponentManifest implements Serializable {
 
     private static final long serialVersionUID = 1L;
 
-    private class ManifestFile implements Serializable {
-        def version
-        def status
-        def commitUTCDate
-        def committer
-        def commitComment
-        Map<String,CompList> compList
-    }
-
     private ManifestFile manifest = null
     private File repoFile = null
 

devops-framework-core/src/main/groovy/org/devops/framework/core/Container.groovy

@@ -5,7 +5,9 @@ package org.devops.framework.core;
 
 import hudson.Launcher
 import hudson.FilePath
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings
 
+@SuppressFBWarnings(value="SE_NO_SERIALVERSIONID")
 class Container implements Serializable {
 
     private static final long serialVersionUID = 1L;
@@ -63,7 +65,7 @@ class Container implements Serializable {
                         cmdStr += it.value
                     }
                 }
-            }
+            }            
             cmdStr += " -d -p "+portNo+":"+portNo
             cmdStr += " --restart=always --name "
             cmdStr += " "+registryName+" "+imageName
@@ -397,7 +399,7 @@ class Container implements Serializable {
                         cmdStr += it.value
                     }
                 }
-            }
+            }            
             if (force) {
                 cmdStr += " -f "
             }

devops-framework-core/src/main/groovy/org/devops/framework/core/ManifestFile.groovy

@@ -0,0 +1,16 @@
+/**
+ * Component list manifest class for use with the framework
+ */
+package org.devops.framework.core;
+
+class ManifestFile implements Serializable {
+    def version
+    def status
+    def commitUTCDate
+    def committer
+    def commitComment
+    Map<String,CompList> compList
+
+    private static final long serialVersionUID = 1L;
+
+}

devops-framework-core/src/main/groovy/org/devops/framework/core/Notifications.groovy

@@ -15,6 +15,9 @@ import javax.mail.PasswordAuthentication
 import java.util.logging.Logger
 import java.util.logging.Level
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings
+
+@SuppressFBWarnings(value="SE_NO_SERIALVERSIONID")
 class Notifications implements Serializable {
 
     private static final Logger LOGGER = Logger.getLogger( Notifications.class.getName() )
@@ -170,7 +173,7 @@ class Notifications implements Serializable {
         try {
             // Create a default MimeMessage object.
             new MimeMessage(session).with { message ->
-
+                @SuppressWarnings("serial")
                 // Add From, Subject and Content
                 from = new InternetAddress( fromEmailAddress )
                 subject = subjectTxt

devops-framework-core/src/main/groovy/org/devops/framework/core/Utilities.groovy

@@ -46,6 +46,9 @@ import jenkins.model.Jenkins
 import java.util.logging.Logger
 import java.util.logging.Level
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings
+
+@SuppressFBWarnings(value="SE_NO_SERIALVERSIONID")
 class Utilities implements Serializable {
 
     private static final Logger LOGGER = Logger.getLogger( Utilities.class.getName() )
@@ -487,7 +490,9 @@ class Utilities implements Serializable {
         props.each {
             mapProp.put(it.key,it.value)
         }
-        mapProp = mapProp.sort { a, b -> a.key <=> b.key }
+        mapProp = mapProp.sort { 
+            a, b -> a.key <=> b.key 
+        }
         return mapProp
     }
 

devops-framework-pipeline/src/main/groovy/org/devops/framework/pipeline/BaseCoordinator.groovy

@@ -11,6 +11,7 @@ import java.util.logging.Level
 class BaseCoordinator implements Serializable {
 
     private static final Logger LOGGER = Logger.getLogger( BaseCoordinator.class.getName() )
+    private static final long serialVersionUID = 1L;
 
     protected steps = null
     protected config = null

devops-framework-pipeline/src/main/groovy/org/devops/framework/pipeline/Build.groovy

@@ -9,6 +9,7 @@ import java.util.logging.Level
 class Build extends BaseCoordinator implements Serializable {
 
     private static final Logger LOGGER = Logger.getLogger( Build.class.getName() )
+    private static final long serialVersionUID = 1L;
 
     /**
      * Default Constructor
@@ -46,14 +47,6 @@ class Build extends BaseCoordinator implements Serializable {
         return super.convertCalloutsToJSON()
     }
 
-    /**
-     * Method to convert callouts to txt
-     * @return String
-     */
-    final String convertCalloutsToTxT() {
-        return super.convertCalloutsToTxT()
-    }
-
     /**
      * Method to run the pipeline
      */

devops-framework-pipeline/src/main/groovy/org/devops/framework/pipeline/CDFramework.groovy

@@ -9,6 +9,7 @@ import java.util.logging.Level
 class CDFramework implements Serializable {
 
     private static final Logger LOGGER = Logger.getLogger( CDFramework.class.getName() )
+    private static final long serialVersionUID = 1L;
 
     // Process objects
     private Integration intProcess = null

devops-framework-pipeline/src/main/groovy/org/devops/framework/pipeline/CIFramework.groovy

@@ -9,6 +9,7 @@ import java.util.logging.Level
 class CIFramework implements Serializable {
 
     private static final Logger LOGGER = Logger.getLogger( CIFramework.class.getName() )
+    private static final long serialVersionUID = 1L;
 
     // Process objects
     private Build buildProcess = null