Added the 'clippy' target to Makefile + changed the GitHub CI 'check' job to invoke the 'clippy' target.

Author: danieltrick

.github/workflows/cargo-workflow.yaml

@@ -25,21 +25,6 @@ on:
         required: true
 
 jobs:
-  # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-  # Code formatting
-  # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-  format:
-    name: cargo fmt
-    runs-on: ubuntu-${{ inputs.OS_VERS_MAX }}
-    steps:
-      - uses: actions/checkout@v7
-      - uses: actions-rust-lang/setup-rust-toolchain@v1
-        with:
-          toolchain: ${{ inputs.TOOLCHAIN_MAX }}
-          cache: false
-          components: rustfmt
-      - uses: actions-rust-lang/rustfmt@v1
-
   # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   # Code checks
   # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -57,21 +42,22 @@ jobs:
         with:
           toolchain: ${{ matrix.rust }}
           cache: false
+          components: rustfmt clippy
       - uses: awalsh128/cache-apt-pkgs-action@v1.6.1
         with:
           packages: pkgconf libtss2-dev uuid-dev libjson-c-dev libcurl4-openssl-dev
           version: v3-${{ matrix.architecture }}-${{ matrix.platform }}-${{ matrix.rust }}-${{ github.run_id }}-check
       - run: |
           pkgconf --path tss2-fapi
           pkgconf --cflags --libs tss2-fapi
-      - run: make check
+      - run: make clippy
 
   # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   # Examples
   # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   examples:
     name: cargo example
-    needs: [format, checks]
+    needs: checks
     strategy:
       matrix:
         platform: ["${{ inputs.OS_VERS_MIN }}", "${{ inputs.OS_VERS_MAX }}"]
@@ -98,7 +84,7 @@ jobs:
   # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   tests-native:
     name: cargo test
-    needs: [format, checks]
+    needs: checks
     strategy:
       matrix:
         platform: ["${{ inputs.OS_VERS_MIN }}", "${{ inputs.OS_VERS_MAX }}"]
@@ -125,7 +111,7 @@ jobs:
   # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   tests-docker:
     name: docker tests
-    needs: [format, checks]
+    needs: checks
     strategy:
       matrix:
         branch: ["stable", "unstable", "bleeding-edge"]
@@ -144,7 +130,7 @@ jobs:
   # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   benches:
     name: benchmarks
-    needs: [format, checks]
+    needs: checks
     strategy:
       matrix:
         platform: ["${{ inputs.OS_VERS_MIN }}", "${{ inputs.OS_VERS_MAX }}"]
@@ -171,7 +157,7 @@ jobs:
   # ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   codecov:
     name: codecov
-    needs: [format, checks]
+    needs: checks
     runs-on: ubuntu-${{ inputs.OS_VERS_MAX }}
     steps:
       - uses: actions/checkout@v7

Makefile

@@ -4,12 +4,21 @@ include tools/docker/docker.mk
 
 DOCKER := $(foreach target,$(DOCKER_TARGETS),docker.$(target))
 
-.PHONY: all bench build check clean codecov docs examples fixup libtpms package publish tests $(DOCKER)
+.PHONY: all bench build check clean clippy codecov docs examples fixup fmt libtpms package publish tests $(DOCKER)
 
 all: clean check build
 
+fmt:
+	cargo fmt --all
+
 check:
-	cargo check --release --locked --all-features --all-targets
+	cargo fmt --all --check
+	cargo check --no-default-features
+	cargo check --release --all-features --all-targets
+
+clippy: check
+	cargo clippy --no-default-features -- -D warnings
+	cargo clippy --all-features --all-targets -- -D warnings
 
 fixup: check
 	cargo upgrade && cargo update