tpm2_makecredential: fix wrong tcg ek templates#3527
Merged
JuergenReppSIT merged 1 commit intoNov 17, 2025
Conversation
shmset
force-pushed
the
fix-wrong-tcg-ek-templates
branch
2 times, most recently
from
4b120f5 to
f8ec865
Compare
The current implementation assumes low-range RSA and ECC keys. Therefore if another key type is used, the default values are used and either the tpm2_makecredential call or the tpm2_activatecredential call fails. This commit reduces the required template values to a minimum and supports additional key types. Fixes: tpm2-software#3526 Signed-off-by: Silas Meier <silas.meier@gapfruit.com>
shmset
force-pushed
the
fix-wrong-tcg-ek-templates
branch
from
f8ec865 to
f80462c
Compare
JuergenReppSIT
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation assumes low-range RSA and ECC keys. Therefore if another key type is used, the default values are used and either the tpm2_makecredential call or the tpm2_activatecredential call fails.
This commit reduces the required template values to a minimum and supports additional key types.
Fixes: #3526