Skip to content

configure.ac: support static toolchains when compiling with hardening #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
winterqt wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

configure.ac: support static toolchains when compiling with hardening #3561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,14 @@ AS_IF([test x"$enable_hardening" != x"no"], [
AX_ADD_FORTIFY_SOURCE

add_hardened_c_flag([-fPIC])
add_hardened_ld_flag([[-shared]])

AC_ARG_ENABLE([shared],
AS_HELP_STRING([--disable-shared], [don't build shared libraries]),,
[enable_shared="yes"]
)
Comment on lines +327 to +330

@winterqt winterqt Feb 25, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a chance that we want to move this outside of the hardened conditional?

AS_IF([test x"$enable_shared" != x"no"], [
add_hardened_ld_flag([[-shared]])

@thesamesam thesamesam Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should drop this entirely: that would fix your problem too.

The project already uses libtool which has machinery for shared and static linking. It is not really a hardening flag at all other than "shared libraries are good" (and I like them!)

])

add_hardened_c_flag([-fPIE])
add_hardened_ld_flag([[-pie]])
Expand Down
Loading