Skip to content

tpm2_util: fix buffer overflow in string validation checks #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JuergenReppSIT merged 1 commit into from
Mar 4, 2026
+4 −6
Merged

tpm2_util: fix buffer overflow in string validation checks #3563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lib/tpm2_util.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,22 +1027,20 @@ bool tpm2_safe_read_from_stdin(int length, char *data) {
bool tpm2_pem_encoded_key_to_fingerprint(const char *pem_encoded_key,
char *fingerprint) {

bool is_pemkey_len_valid = strlen(pem_encoded_key) > 1024 ? false : true;
if (!is_pemkey_len_valid) {
if (strlen(pem_encoded_key) >= 1024) {
return false;
}

char str[1024] = "";
strcpy(str, pem_encoded_key);
strncpy(str, pem_encoded_key, 1023);
str[1023] = '\0';

/* walk through other tokens */
char base64[1024] = "";
char *token = strtok(str, "\n");
while ( token != NULL ) {
if (!strstr(token, "-----")) {
bool is_base64_overrun = (strlen(base64) + strlen(token)) > 1024 ?
true : false;
if (is_base64_overrun) {
if ((strlen(base64) + strlen(token)) >= 1024) {
return false;
}
strcat(base64, token);
Expand Down