tpm2_loadexternal: check return value of RAND_bytes#3569
Merged
AndreasFuchsTPM merged 1 commit intoMar 25, 2026
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hyperfinitism
force-pushed
the
fix/rand-bytes-rc-check
branch
from
5ee0c76 to
9764a44
Compare
RAND_bytes() can fail with return code 0 or -1 when the OpenSSL CSPRNG has not been sufficiently seeded. If RAND_bytes() fails, seed->buffer is left uninitialised. This seed value is stored in ctx.priv.sensitiveArea.seedValue and used in the consistency checks by TPM. Check the return value and return tool_rc_general_error on failure so that the operation is aborted rather than proceeding with a bad seed. Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
hyperfinitism
force-pushed
the
fix/rand-bytes-rc-check
branch
from
9764a44 to
be2acae
Compare
JuergenReppSIT
approved these changes
Mar 23, 2026
AndreasFuchsTPM
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RAND_bytes()can fail with return code 0 or -1. If it fails,seed->bufferis not ensured to have sufficient entropy. This PR adds the return value check.