Feature: Provide sm2 algorithm support#278
Open
bangcheng wants to merge 1 commit into
Open
Conversation
bangcheng
changed the title
This code is to enable tpm2-tss-engine to support the SM2 algorithm. Signed-off-by: bangcheng <bangwangnj@163.com>
bangcheng
force-pushed
the
master
branch
2 times, most recently
from
fedf5f9 to
e33231f
Compare
kalvdans
approved these changes
Jun 17, 2026
kalvdans
left a comment
kalvdans
left a comment
There was a problem hiding this comment.
looks neat to me. Haven't tested it though.
| // call pkey_sm2_sign_default | ||
| return pkey_sm2_sign_default(ctx, sig, siglen, tbs, tbslen); | ||
| } | ||
| else { |
There was a problem hiding this comment.
no need for an else clause here, as we already returned if taken the if clause.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is to enable tpm2-tss-engine to support the SMx algorithm. (#277)