Makefile.am: Fix build without pandoc#285
Open
barsnick wants to merge 1 commit into
Open
Conversation
barsnick
added a commit
to chargebyte/meta-chargebyte-distro
that referenced
this pull request
Sep 19, 2024
This fixes failed attempts to build the man pages even tough pandoc is not present. Fixes tpm2-software/tpm2-tss-engine#284, with patch from tpm2-software/tpm2-tss-engine#285. Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
AndreasFuchsTPM
requested changes
Oct 10, 2024
AndreasFuchsTPM
left a comment
AndreasFuchsTPM
left a comment
Member
There was a problem hiding this comment.
Please add a Signed-of-by tag
Author
I have no idea why the DCO check fails to see it. It's been there all along. |
Author
Ah, I got it. It needs to be identical to the author. |
When building from a tarball, pre-created man pages are preset. Yet `make clean` clobbers them, leaving their target directory intact. Therefore, the next configure call will try to build man pages even if pandoc isn't available. Fix this by cleaning the man pages only if they can be recreated by the presence of pandoc. Fixes tpm2-software#284 Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
barsnick
force-pushed
the
fix-build-without-pandoc
branch
from
d5b9b97 to
c345381
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building from a tarball, pre-created man pages are preset. Yet
make cleanclobbers them, leaving their target directory intact. Therefore, the next configure call will try to build man pages even if pandoc isn't available.Fix this by cleaning the man pages only if they can be recreated by the presence of pandoc.
Fixes #284