Fix hyperion-project#977: return error reply for unknown adjustment id

tpmodding · claude · tpmodding · commit e24c3de8a0f9 · 2026-05-01T13:50:01.000+02:00
Previously the handler silently returned without notifying the caller,
resulting in a false success response.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/libsrc/api/JsonAPI.cpp b/libsrc/api/JsonAPI.cpp
@@ -881,7 +881,7 @@ void JsonAPI::handleAdjustmentCommand(const QJsonObject &message, const JsonApiC
 	const QString adjustmentId = adjustment["id"].toString(adjustmentIds.first());
 	ColorAdjustment* colorAdjustment = hyperion->getAdjustment(adjustmentId);
 	if (colorAdjustment == nullptr) {
-		Warning(_log, "Incorrect adjustment identifier: %s", adjustmentId.toStdString().c_str());
+		sendErrorReply(QString("Incorrect adjustment identifier: %1").arg(adjustmentId), cmd);
 		return;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -881,7 +881,7 @@ void JsonAPI::handleAdjustmentCommand(const QJsonObject &message, const JsonApiC`
`881`	`881`	`const QString adjustmentId = adjustment["id"].toString(adjustmentIds.first());`
`882`	`882`	`ColorAdjustment* colorAdjustment = hyperion->getAdjustment(adjustmentId);`
`883`	`883`	`if (colorAdjustment == nullptr) {`
`884`		`- Warning(_log, "Incorrect adjustment identifier: %s", adjustmentId.toStdString().c_str());`
	`884`	`+ sendErrorReply(QString("Incorrect adjustment identifier: %1").arg(adjustmentId), cmd);`
`885`	`885`	`return;`
`886`	`886`	`}`
`887`	`887`