wip: add a new legendgroup parameter

Author: tpvasconcelos

cicd_utils/ridgeplot_examples/_lincoln_weather.py

@@ -27,8 +27,9 @@ def main(
 
     fig = ridgeplot(
         samples=samples,
-        labels=[["Min Temperature [F]", "Max Temperature [F]"]] * len(months),
+        labels=[["Min Temperatures", "Max Temperatures"]] * len(months),
         row_labels=months,
+        legendgroup=True,
         colorscale="Inferno",
         color_discrete_map=color_discrete_map,
         bandwidth=4,
@@ -46,7 +47,12 @@ def main(
         xaxis_gridwidth=2,
         yaxis_title="Month",
         xaxis_title="Temperature [F]",
-        showlegend=False,
+        legend=dict(
+            yanchor="top",
+            y=0.99,
+            xanchor="right",
+            x=0.99,
+        ),
     )
 
     return fig

cicd_utils/ridgeplot_examples/_lincoln_weather_red_blue.py

@@ -11,8 +11,8 @@
 def main() -> go.Figure:
     fig = lincoln_weather(
         color_discrete_map={
-            "Min Temperature [F]": "deepskyblue",
-            "Max Temperature [F]": "orangered",
+            "Min Temperatures": "deepskyblue",
+            "Max Temperatures": "orangered",
         }
     )
     return fig

docs/_static/charts/lincoln_weather.webp

@@ -134,8 +134,9 @@ samples = [
 # And finish by styling it up to your liking!
 fig = ridgeplot(
     samples=samples,
-    labels=[["Min Temperature [F]", "Max Temperature [F]"]] * len(months),
+    labels=[["Min Temperatures", "Max Temperatures"]] * len(months),
     row_labels=months,
+    legendgroup=True,
     colorscale="Inferno",
     bandwidth=4,
     kde_points=np.linspace(-40, 110, 400),
@@ -152,7 +153,12 @@ fig.update_layout(
     xaxis_gridwidth=2,
     yaxis_title="Month",
     xaxis_title="Temperature [F]",
-    showlegend=False,
+    legend=dict(
+        yanchor="top",
+        y=0.99,
+        xanchor="right",
+        x=0.99,
+    ),
 )
 fig.show()
 ```
@@ -229,14 +235,14 @@ Finally, we can pass the {py:paramref}`~ridgeplot.ridgeplot.samples` list to the
 ```python
 fig = ridgeplot(
     samples=samples,
-    labels=[["Min Temperature [F]", "Max Temperature [F]"]] * len(months),
+    labels=[["Min Temperatures", "Max Temperatures"]] * len(months),
     row_labels=months,
+    legendgroup=True,
     colorscale="Inferno",
     bandwidth=4,
     kde_points=np.linspace(-40, 110, 400),
     spacing=0.3,
 )
-
 fig.update_layout(
     title="Minimum and maximum daily temperatures in Lincoln, NE (2016)",
     height=600,
@@ -248,7 +254,12 @@ fig.update_layout(
     xaxis_gridwidth=2,
     yaxis_title="Month",
     xaxis_title="Temperature [F]",
-    showlegend=False,
+    legend=dict(
+        yanchor="top",
+        y=0.99,
+        xanchor="right",
+        x=0.99,
+    ),
 )
 fig.show()
 ```
@@ -277,8 +288,8 @@ fig = ridgeplot(
     # addition of `color_discrete_map`
     # ...
     color_discrete_map={
-        "Min Temperature [F]": "deepskyblue",
-        "Max Temperature [F]": "orangered",
+        "Min Temperatures": "deepskyblue",
+        "Max Temperatures": "orangered",
     }
     # ...
 )

docs/_static/charts/lincoln_weather_red_blue.webp

@@ -13,6 +13,7 @@
     SolidColormode,
     compute_solid_colors,
 )
+from ridgeplot._obj.legendcontext import LegendContextManager
 from ridgeplot._obj.traces import get_trace_cls
 from ridgeplot._obj.traces.base import ColoringContext
 from ridgeplot._types import (
@@ -123,6 +124,7 @@ def create_ridgeplot(
     trace_labels: LabelsArray | ShallowLabelsArray | None,
     trace_types: TraceTypesArray | ShallowTraceTypesArray | TraceType,
     row_labels: Collection[str] | None | Literal[False],
+    legendgroup: bool,
     colorscale: ColorScale | Collection[Color] | str | None,
     colormode: Literal["fillgradient"] | SolidColormode,
     color_discrete_map: dict[str, str] | None,
@@ -176,6 +178,8 @@ def create_ridgeplot(
     # ---  Build the figure
     # ==============================================================
 
+    legend_ctx_manager = LegendContextManager(legendgroup=legendgroup)
+
     interpolation_ctx = InterpolationContext(
         densities=densities,
         n_rows=n_rows,
@@ -209,7 +213,7 @@ def create_ridgeplot(
         ):
             trace_drawer = get_trace_cls(trace_type)(
                 trace=trace,
-                label=label,
+                legend_ctx=legend_ctx_manager.get_legend_ctx(label=label),
                 solid_color=color,
                 zorder=ith_trace,
                 y_base=y_base,

docs/getting_started/getting_started.md

@@ -0,0 +1,60 @@
+from __future__ import annotations
+
+import dataclasses
+from typing import Any, TypedDict
+
+
+class Font(TypedDict, total=False):
+    # plotly/graph_objs/scatter/legendgrouptitle/_font.py
+    color: str | None
+    family: str | None
+    lineposition: str | None
+    shadow: str | None
+    size: int | float | None
+    style: str | None
+    textcase: str | None
+    variant: str | None
+    weight: int | None
+
+
+class Legendgrouptitle(TypedDict, total=False):
+    # plotly/graph_objs/scatter/_legendgrouptitle.py
+    text: str | None
+    font: Font | None
+
+
+@dataclasses.dataclass
+class LegendContext:
+    name: str
+    showlegend: bool
+    legendgroup: str | int | float | None = None
+    legendgrouptitle: Legendgrouptitle | None = None
+
+    @property
+    def trace_kwargs(self) -> dict[str, Any]:
+        return dataclasses.asdict(self)
+
+
+class LegendContextManager:
+    def __init__(self, legendgroup: bool) -> None:
+        super().__init__()
+        self.legendgroup = legendgroup
+        self._seen_labels: set[str] = set()
+
+    def get_legend_ctx(self, label: str) -> LegendContext:
+        if not self.legendgroup:
+            return LegendContext(name=label, showlegend=True)
+        if label not in self._seen_labels:
+            self._seen_labels.add(label)
+            return LegendContext(
+                name=label,
+                showlegend=True,
+                legendgroup=label,
+                # FIXME: This doesn't seem to work as expected
+                # legendgrouptitle=Legendgrouptitle(text=label),
+            )
+        return LegendContext(
+            name=label,
+            showlegend=False,
+            legendgroup=label,
+        )

src/ridgeplot/_figure_factory.py

@@ -68,6 +68,7 @@ def draw(self, fig: go.Figure, coloring_ctx: ColoringContext) -> go.Figure:
                 hoverinfo="skip",
                 # z-order (higher z-order means the trace is drawn on top)
                 zorder=self.zorder,
+                legendgroup=self.legend_ctx.legendgroup,
             )
         )
         fig.add_trace(

src/ridgeplot/_obj/legendcontext.py

@@ -12,6 +12,7 @@
     from plotly import graph_objects as go
 
     from ridgeplot._color.interpolation import InterpolationContext
+    from ridgeplot._obj.legendcontext import LegendContext
     from ridgeplot._types import Color, ColorScale, DensityTrace
 
 
@@ -24,7 +25,7 @@
 string below, but it's not quite the same... (see '.7~r' as well)
 """
 
-DEFAULT_HOVERTEMPLATE = (
+_DEFAULT_HOVERTEMPLATE = (
     f"(%{{x:{_D3HF}}}, %{{customdata[0]:{_D3HF}}})"
     "<br>"
     "<extra>%{fullData.name}</extra>"
@@ -56,7 +57,7 @@ def __init__(
         self,
         *,  # kw only
         trace: DensityTrace,
-        label: str,
+        legend_ctx: LegendContext,
         solid_color: str,
         zorder: int,
         # Constant over the trace's row
@@ -67,7 +68,7 @@ def __init__(
     ):
         super().__init__()
         self.x, self.y = zip(*trace, strict=True)
-        self.label = label
+        self.legend_ctx = legend_ctx
         self.solid_color = solid_color
         self.zorder = zorder
         self.y_base = y_base
@@ -79,12 +80,10 @@ def _common_trace_kwargs(self) -> dict[str, Any]:
         """Return common trace kwargs."""
         return dict(
             # Legend information
-            name=self.label,
-            # legendgroup=self.label,
-            # legendgrouptitle_text=self.label,
+            **self.legend_ctx.trace_kwargs,
             # Hover information
             customdata=[[y_i] for y_i in self.y],
-            hovertemplate=DEFAULT_HOVERTEMPLATE,
+            hovertemplate=_DEFAULT_HOVERTEMPLATE,
             # z-order (higher z-order means the trace is drawn on top)
             zorder=self.zorder,
         )

src/ridgeplot/_obj/traces/area.py

@@ -102,6 +102,7 @@ def ridgeplot(
     trace_type: TraceTypesArray | ShallowTraceTypesArray | TraceType | None = None,
     labels: LabelsArray | ShallowLabelsArray | None = None,
     row_labels: Collection[str] | None | Literal[False] = None,
+    legendgroup: bool = False,  # TODO: document and rename to smth better!
     # KDE parameters
     kernel: str = "gau",
     bandwidth: KDEBandwidth = "normal_reference",
@@ -503,6 +504,7 @@ def ridgeplot(
         trace_labels=labels,
         trace_types=trace_type,
         row_labels=row_labels,
+        legendgroup=legendgroup,
         colorscale=colorscale,
         colormode=colormode,
         color_discrete_map=color_discrete_map,