Set mime based on name when passing a string to putObject#100
Open
kensnyder wants to merge 1 commit intotpyo:masterfrom
Open
Set mime based on name when passing a string to putObject#100kensnyder wants to merge 1 commit intotpyo:masterfrom
kensnyder wants to merge 1 commit intotpyo:masterfrom
Conversation
- New function _getMIMETypeByFilename with an extensive lookup of extensions - Call that function within _getMIMEType before using the fileinfo extension
Contributor
There was a problem hiding this comment.
Would be nice if these were alphabetically sorted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extensions
extension