Only set the FOLLOWLOCATION curl opt if we are not in safe mode#26
Open
leto wants to merge 1 commit intotpyo:masterfrom
Chirpify:followlocation
Open
Only set the FOLLOWLOCATION curl opt if we are not in safe mode#26leto wants to merge 1 commit intotpyo:masterfrom Chirpify:followlocation
leto wants to merge 1 commit intotpyo:masterfrom
Chirpify:followlocation
Conversation
|
Safe mode isn't the only situation where setting FOLLOWLOCATION will produce a warning. A better solution is provided here: #21 |
|
Hope this pull request gets merged soon, just hit the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small patch allows the S3 library to be used in safe mode. Without this patch, it cannot be used in safe mode because the FOLLOWLOCATION curl opt is only allowed when not in safe mode.