Add support for getting only portions of objects via HTTP range requests#58
Open
greenlion wants to merge 2 commits intotpyo:masterfrom
Open
Add support for getting only portions of objects via HTTP range requests#58greenlion wants to merge 2 commits intotpyo:masterfrom
greenlion wants to merge 2 commits intotpyo:masterfrom
Conversation
Closed
Author
|
sorry it is a bit of a dirty push. I was in a hurry. I can clean it up and make any changes you request if you like. I didn't see issue #10, I just wrote this for myself and pushed it. |
Author
|
did you add this functionality? if not, can you pull it as is. it has languished. if you don't want to pull it, what changes to do you want? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made getObject() take a forth parameter. Now the third or fourth parameter may be an array (the forth is an array if the third is a filename or resource). If an array is passed in, then it should have two indices [0] and [1] which point to start and end bytes, respectively.
ie:
$first_ten_bytes = S3::getObject($bucketName, $uploadName, array(1,10));
Of course, if no range is passed in, then the whole object is retrieved.