Skip to content

Commit 7e64ac3

Browse files
authored
on pull_request_targetからpull_requestに変更 (#1205)
セキュリティリスクのわりに、外部からのPRはそこまで多くないので、修正
1 parent 6472c1d commit 7e64ac3

2 files changed

Lines changed: 2 additions & 7 deletions

File tree

.github/workflows/preview-comment.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
name: Comment preview environment URL
22

33
on:
4-
# pull_request_target を使うにあたって https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ の一読を推奨
5-
pull_request_target:
4+
pull_request:
65
types:
76
- opened
87

.github/workflows/preview.yaml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
name: Preview
22

33
on:
4-
# pull_request_target を使うにあたって https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ の一読を推奨
5-
pull_request_target:
4+
pull_request:
65

76
permissions:
87
packages: write
@@ -16,9 +15,6 @@ jobs:
1615
run: echo "PR_NUMBER=${{ github.event.number }}" >> $GITHUB_ENV
1716

1817
- uses: actions/checkout@v6
19-
with:
20-
ref: ${{ github.event.pull_request.head.sha }}
21-
persist-credentials: false
2218
- run: echo "APP_VERSION=preview-${{ env.PR_NUMBER }}" >> $GITHUB_ENV
2319
- run: echo "APP_REVISION=$(git rev-parse --short HEAD)" >> $GITHUB_ENV
2420

0 commit comments

Comments
 (0)