Skip to content

test#4999

Draft
uni-kakurenbo wants to merge 1 commit intomasterfrom
fix/webkit-notification-popup
Draft

test#4999
uni-kakurenbo wants to merge 1 commit intomasterfrom
fix/webkit-notification-popup

Conversation

@uni-kakurenbo
Copy link
Copy Markdown
Contributor

概要

なぜこの PR を入れたいのか

動作確認の手順

UI 変更部分のスクリーンショット

before

after

PR を出す前の確認事項

  • (機能の追加なら)追加することの合意がチームで取れている
    • 取れていない場合はチェックを外して PR にすれば OK
  • 動作確認ができている
  • 自分で一度コードを眺めて自分的に問題はなさそう

見てほしいところ・聞きたいことなど

@uni-kakurenbo uni-kakurenbo marked this pull request as draft December 29, 2025 11:30
@github-actions
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 29, 2025

Codecov Report

❌ Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.52%. Comparing base (ecb0d1d) to head (a72226e).

Files with missing lines Patch % Lines
src/lib/basic/timer.ts 11.11% 8 Missing ⚠️
src/lib/notification/notification.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4999      +/-   ##
==========================================
- Coverage   61.01%   60.52%   -0.49%     
==========================================
  Files         101      101              
  Lines        2970     2987      +17     
  Branches      615      621       +6     
==========================================
- Hits         1812     1808       -4     
- Misses       1061     1085      +24     
+ Partials       97       94       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@uni-kakurenbo uni-kakurenbo force-pushed the fix/webkit-notification-popup branch from a72226e to 3c61b57 Compare December 29, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant