Skip to content

Fix: Handle ToolNode in tools iteration for LangGraph compatibility #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Utkarshkhandka wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: Handle ToolNode in tools iteration for LangGraph compatibility #3946

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0546abf
Fix: Handle ToolNode in tools iteration for LangGraph compatibility
Utkarshkhandka Apr 2, 2026
9228d8c
Fix comment punctuation and refactor tool extraction
Utkarshkhandka Apr 3, 2026
eefffb2
Refactor tool extraction logic in patch.py
Utkarshkhandka Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .../opentelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ def wrapper(wrapped, _instance, args, kwargs):
span.set_attribute(GenAIAttributes.GEN_AI_AGENT_NAME, agent_name)

# Extract system instructions from prompt/system_prompt parameter
# LangGraph uses "prompt", LangChain uses "system_prompt"
# LangGraph uses "prompt", LangChain uses "system_prompt."
system_instructions = kwargs.get("prompt") or kwargs.get("system_prompt")
if system_instructions:
if isinstance(system_instructions, str):
Expand All @@ -486,7 +486,14 @@ def wrapper(wrapped, _instance, args, kwargs):
tools = args[1]
if tools:
tool_definitions = []
for tool in tools:
if hasattr(tools, "tools_by_name"):
iterable_tools = tools.tools_by_name.values()
elif isinstance(tools, (list, tuple, set)):
iterable_tools = tools
else:
iterable_tools = [tools]

for tool in iterable_tools:
tool_def = _extract_tool_definition(tool)
if tool_def:
tool_definitions.append(tool_def)
Expand Down