fix(qdrant): add query_points and query_batch_points to async client instrumentation#4196
fix(qdrant): add query_points and query_batch_points to async client instrumentation#4196william-xue wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe async Qdrant instrumentation mapping adds two new span definitions for AsyncQdrantClient: ChangesAsync Qdrant client instrumentation extensions
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
|
I have read the CLA Document and I hereby sign the CLA recheck |
…instrumentation The sync QdrantClient had query_points and query_batch_points in its instrumentation config, but AsyncQdrantClient was missing both methods. This caused async users to not get spans for these operations. Closes traceloop#3492
e61bd87 to
a4e0780
Compare
|
Rebased this branch on the latest upstream recheck |
|
@traceloop maintainers: I rebased the branch and updated the only commit so both author and committer resolve to my GitHub account Could you please re-run/refresh the CLA check or advise if another signature step is needed? |
Summary
The sync
QdrantClientinstrumentation includesquery_pointsandquery_batch_pointsin its method config, but the asyncAsyncQdrantClientconfig was missing both. This means async users get no tracing spans when calling these methods.This PR adds the two missing entries to
async_qdrant_client_methods.json, bringing async instrumentation to parity with the sync client.The instrumentor already uses
hasattrchecks (line 55 in__init__.py), so this is safe across all qdrant-client versions — if a version doesn't have these methods, they're silently skipped.Changes
query_pointsandquery_batch_pointstoasync_qdrant_client_methods.jsonTest plan
pytest tests/ -vAsyncQdrantClienthas bothquery_pointsandquery_batch_pointsmethods (qdrant-client 1.18.0)Related issues
opentelemetry-instrumentation-qdrantis incompatible withqdrant-clientversion1.16.1#3492 (follow-up on async coverage gap noted in this comment)Summary by CodeRabbit