Conversation
|
Thanks Xinli. A quick question: does this include treemap? Also, can you include in the PR body a GIF of the template so that everyone knows what it looks like? I find this website to be useful to upload gifs generate external links: https://giphy.com/ In any case, we need to find some time to sit down and have all these three templates merged (pie, treemap, circle packing, anything else?) |
|
feature request: add option to opt out breadcrumb |
tracyhenry
left a comment
tracyhenry
left a comment
There was a problem hiding this comment.
Thanks for the PR Xinli. See my inline comments.
Sorry that there are a lot, but majority of them are minor/my questions.
|
Can you also check that your Java line endings are correct. It seems like some of them are using CRLF |
| @@ -0,0 +1,79 @@ | |||
| package project; | |||
There was a problem hiding this comment.
TODO: test if this can be moved to an indexer file.
There was a problem hiding this comment.
Nashorn failed even though PackNode is in the same file. Seems that Nashorn only supports public classes
There was a problem hiding this comment.
I think one way is not passing ArrayList<PackNode> into nashorn...
Serialize packnodes to string before hand, then deserialize in packSib...
2 participants
Circle Packing
list of modifications:
this is a demo using the word frequency data set:
This is the first pull request of hierarchical templates, and it was derived from a very old code base, many files have been changed. Thank you for any comments, criticism and discussion!