feat: add hub-manager chart#1784
Open
bpsoraggi wants to merge 69 commits into
Open
Conversation
darkweaver87
reviewed
Apr 3, 2026
darkweaver87
reviewed
Apr 3, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 7, 2026
mloiseleur
reviewed
Apr 8, 2026
mloiseleur
reviewed
Apr 8, 2026
mloiseleur
reviewed
Apr 8, 2026
mloiseleur
reviewed
Apr 8, 2026
bpsoraggi
force-pushed
the
feat/hub-manager-chart
branch
from
665e140 to
35587d5
Compare
youkoulayley
requested changes
Apr 9, 2026
This comment was marked as resolved.
This comment was marked as resolved.
youkoulayley
requested changes
Apr 15, 2026
| apiVersion: batch/v1 | ||
| kind: Job | ||
| metadata: | ||
| name: {{ include "hub-manager.fullname" . }}-migration |
Contributor
There was a problem hiding this comment.
This job is not tested. Also for a migration job it might require a backoffLimit, probably to 0. Also we may add the same scheduling options as for the deployment so that people can schedule this job wherever they want.
Contributor
Author
There was a problem hiding this comment.
Regarding the scheduling, this job is actually a chart hook. The available hooks are documented here
Contributor
There was a problem hiding this comment.
I know what is a chart hook but I speak about kubelet scheduling like affinity/anti-affinity, tolerations, etc. It still remains a pod we have a execute somewhere at some point :-)
Contributor
There was a problem hiding this comment.
affinity is honored by the Deployment but not by this Job, so a user setting .Values.affinity would see the migration Pod land somewhere different from the workload.
bpsoraggi
force-pushed
the
feat/hub-manager-chart
branch
from
ca443c9 to
bbf2d8e
Compare
mloiseleur
reviewed
May 7, 2026
mloiseleur
reviewed
May 7, 2026
darkweaver87
approved these changes
May 7, 2026
Contributor
darkweaver87
left a comment
darkweaver87
left a comment
There was a problem hiding this comment.
LGTM once @mloiseleur changes will be applied.
mloiseleur
reviewed
May 12, 2026
Member
|
@bpsoraggi After rebase, it will require for changelog something similar of what we have done for CRD chart:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds new
hub-managerchartMotivation
To include the new chart in the repository
More
make testand all the tests passed