interp: default to None for non-valued statements#1079
Open
firelizzard18 wants to merge 1 commit into
Open
Conversation
mvertes
added
area/core
enhancement
Collaborator
|
The current state is not consistent. It would be better to always disable result output for assignment rather than adding an option, for consistency and simplicity. Could you modify your PR in that direction ? |
Update AST to use EmptyResult instead of new(interface{}) as the default
val for a node. Update genValue to always return node.val for variable
declaration, definition, and assignment.
firelizzard18
force-pushed
the
feature/no-assignment-output
branch
from
b68b7dc to
3df4420
Compare
firelizzard18
changed the title
Contributor
Author
|
@mvertes This is ready for review. Now, all variable declarations and assignments return the special value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here am using 'None' to refer to the functional programming concept of an empty result. I added
interp.EmptyResultsince that is far clearer than 'None', especially to users not familiar with functional programming jargon.Updates
*Interpreter.astto useval: EmptyResultas the default, instead ofnew(interface{}). UpdatesgenValueto always returnnode.valfor a block statement where the last statement isvar x = 1,x := 1, orx = 1.As a result, variable declarations and assignments return a value of
interp.EmptyResult.