Make #from_hash raise TypeError when arg not Hash

Signed-off-by: Alex Coles <alex@alexbcoles.com>

Author: myabc

lib/representable/hash.rb

@@ -26,6 +26,7 @@ def collection_representer_class
 
     def from_hash(data, options={}, binding_builder=Binding)
       data = filter_wrap(data, options)
+      raise TypeError, "Expected Hash, got #{data.class}." unless ::Hash === data
 
       update_properties_from(data, options, binding_builder)
     end

test/hash_test.rb

@@ -27,6 +27,13 @@ class HashWithScalarPropertyTest < MiniTest::Spec
       album.title.must_equal nil
       album.extend(representer).from_hash("title" => nil)
     end
+
+    it 'raises a TypeError when argument is not a Hash' do
+      from_hash = -> {
+        album.extend(representer).from_hash('not Hashish')
+      }.must_raise TypeError
+      from_hash.message.must_equal 'Expected Hash, got String.'
+    end
   end
 end
 
@@ -157,4 +164,4 @@ class HashWithScalarCollectionTest < MiniTest::Spec
       album.extend(representer).from_hash("songs" => ["Off Key Melody", "Sinking"]).must_equal Album.new(["Off Key Melody", "Sinking"])
     end
   end
-end
+end

test/wrap_test.rb

@@ -80,6 +80,11 @@ class BandDecorator < Representable::Decorator
     band.from_hash({band: {"name"=>"Social Distortion"}}, wrap: :band).name.must_equal "Social Distortion"
   end
 
+  it 'raises a TypeError when unwrapped argument is not a Hash' do
+    -> { band.from_hash('bands' => '')         }.must_raise TypeError
+    -> { band.from_hash('', wrap: false)       }.must_raise TypeError
+    -> { band.from_hash({'band' => ''}, wrap: :band) }.must_raise TypeError
+  end
 
   class AlbumDecorator < Representable::Decorator
     include Representable::Hash
@@ -149,4 +154,3 @@ class AlbumDecorator < Representable::Decorator
   #   album.from_hash({"albums" => {"band" => {"name"=>"Rvivr"}}}).band.name.must_equal "Rvivr"
   # end
 end
-