[pull] master from golang:master#126
Merged
Merged
Conversation
The -failfast flag stops a test binary from starting new tests after the first failure. When a test had a parallel subtest, its failure was recorded before its cleanup functions ran. A failure inside a t.Cleanup was therefore not counted, and -failfast kept starting new tests. Tests without a parallel subtest run their cleanup earlier and were unaffected. Record the failure after cleanup has run, so a cleanup failure counts for -failfast regardless of whether the test has a parallel subtest. Fixes #61034 Change-Id: Icea654cbaf3904936200566d7d7d72ca8ccc5958 GitHub-Last-Rev: e46ad5a GitHub-Pull-Request: #80165 Reviewed-on: https://go-review.googlesource.com/c/go/+/794541 Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )